Skip to content

feat: migrate and apply crossRegionPresignedUrlMiddleware #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Jan 10, 2020

Migrates and applies crossRegionPresignedUrlMiddleware for RDS clients

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase changed the title feat: rds presign middleware feat: migrate and apply crossRegionPresignedUrlMiddleware Jan 10, 2020
@srchase srchase requested a review from AllanZhengYP January 10, 2020 21:28
@srchase srchase added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Jan 10, 2020
@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AllanZhengYP
Copy link
Contributor

Merge it when query protocol is ready and have tested this agains RDS client.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 95c26c4 into aws:smithy-codegen Jan 15, 2020
trivikr added a commit that referenced this pull request Jan 15, 2020
@trivikr
Copy link
Member

trivikr commented Jan 15, 2020

The code was reverted using force-push, and re-added as we were testing what happens when remote gets updated during release.

  • re-added commit while release was in progress 3e24d71
  • merge commit 85fb6b6

Release https://github.com/aws/aws-sdk-js-v3/releases/tag/v1.0.0-alpha.6

@lock
Copy link

lock bot commented Jan 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants