Skip to content

Commit 0853932

Browse files
committed
fix: fix lint and unused import + verify depends on step instance in integ test
1 parent ae85184 commit 0853932

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

src/sagemaker/workflow/steps.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,7 @@ def to_request(self) -> RequestType:
9191
return request_dict
9292

9393
def add_depends_on(self, step_names: Union[List[str], List["Step"]]):
94-
"""
95-
Add step names to the current step depends on list
96-
97-
Args:
98-
step_names (List[str] or List[Step]): A list of step name strings or step instances
99-
"""
94+
"""Add step names or stpe instances to the current step depends on list"""
10095

10196
if not step_names:
10297
return

tests/integ/test_workflow.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1083,7 +1083,7 @@ def test_two_processing_job_depends_on(
10831083

10841084
step_pyspark_2 = ProcessingStep(
10851085
name="pyspark-process-2",
1086-
depends_on=[step_pyspark_1.name],
1086+
depends_on=[step_pyspark_1],
10871087
processor=pyspark_processor,
10881088
inputs=spark_run_args.inputs,
10891089
outputs=spark_run_args.outputs,

tests/integ/test_workflow_with_clarify.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@
3333
from sagemaker.processing import ProcessingInput, ProcessingOutput
3434
from sagemaker.session import get_execution_role
3535
from sagemaker.workflow.conditions import ConditionLessThanOrEqualTo
36-
from sagemaker.workflow.condition_step import ConditionStep, JsonGet
36+
from sagemaker.workflow.condition_step import ConditionStep
37+
from sagemaker.workflow.functions import JsonGet
3738
from sagemaker.workflow.parameters import (
3839
ParameterInteger,
3940
ParameterString,

0 commit comments

Comments
 (0)