Skip to content

Commit 09789e6

Browse files
author
Ignacio Quintero
committed
Add changelog entry and a comment on the unit test
1 parent a1f6595 commit 09789e6

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

CHANGELOG.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ CHANGELOG
88
* bug-fix: Unit Tests: Improve unit test runtime
99
* bug-fix: Estimators: Fix attach for LDA
1010
* bug-fix: Estimators: allow code_location to have no key prefix
11+
* bug-fix: Local Mode: Fix s3 training data download when there is a trailing slash
12+
1113

1214
1.4.1
1315
=====

tests/unit/test_image.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,6 +368,7 @@ def test_download_folder(makedirs):
368368
obj_mock.download_file.assert_has_calls(calls)
369369
obj_mock.reset_mock()
370370

371+
# Testing with a trailing slash for the prefix.
371372
sagemaker_container._download_folder(BUCKET_NAME, '/prefix/', '/tmp')
372373
obj_mock.download_file.assert_called()
373374
calls = [call(os.path.join('/tmp', 'train/train_data.csv')),

0 commit comments

Comments
 (0)