Skip to content

Commit 0e50790

Browse files
author
Ignacio Quintero
committed
Add exception for async tensorboard and fix tests.
Fix the PCA and factorization machines async fit integration tests and add an exception when running Tensorboard with async fit.
1 parent e595cc5 commit 0e50790

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

src/sagemaker/tensorflow/estimator.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,9 @@ def fit(self, inputs, wait=True, logs=True, job_name=None, run_tensorboard_local
152152
def fit_super():
153153
super(TensorFlow, self).fit(inputs, wait, logs, job_name)
154154

155+
if run_tensorboard_locally and wait is False:
156+
raise ValueError("Tensorboard is not supported with async fit")
157+
155158
if run_tensorboard_locally:
156159
tensorboard = Tensorboard(self)
157160
tensorboard.validate_requirements()

tests/integ/test_factorization_machines.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def test_factorization_machines():
5959
def test_async_factorization_machines():
6060

6161
training_job_name = ""
62-
endpoint_name = name_from_base('factorization_machines')
62+
endpoint_name = name_from_base('factorizationMachines')
6363
sagemaker_session = sagemaker.Session(boto_session=boto3.Session(region_name=REGION))
6464

6565
with timeout(minutes=5):

tests/integ/test_pca.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def test_pca():
6363
def test_async_pca():
6464

6565
training_job_name = ""
66-
endpoint_name = name_from_base('async_pca')
66+
endpoint_name = name_from_base('pca')
6767
sagemaker_session = sagemaker.Session(boto_session=boto3.Session(region_name=REGION))
6868

6969
with timeout(minutes=20):

0 commit comments

Comments
 (0)