Skip to content

Commit 0f35930

Browse files
author
Raymond Liu
committed
more formatting
1 parent f2ed8f4 commit 0f35930

File tree

5 files changed

+29
-20
lines changed

5 files changed

+29
-20
lines changed

src/sagemaker/inference_recommender/inference_recommender_mixin.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,9 @@ def right_size(
149149
self._init_sagemaker_session_if_does_not_exist()
150150

151151
self.temp_model_name = None
152-
if isinstance(self, sagemaker.model.Model) and not isinstance(self, sagemaker.model.ModelPackage):
152+
if isinstance(self, sagemaker.model.Model) and not isinstance(
153+
self, sagemaker.model.ModelPackage
154+
):
153155

154156
unique_tail = uuid.uuid4()
155157
self.temp_model_name = "SMPYTHONSDK-" + str(unique_tail)
@@ -160,10 +162,13 @@ def right_size(
160162
container_defs=None,
161163
primary_container=self.prepare_container_def(),
162164
vpc_config=self.vpc_config,
163-
enable_network_isolation=self.enable_network_isolation()
165+
enable_network_isolation=self.enable_network_isolation(),
166+
)
167+
print(
168+
f"Creating temporary model with name: {self.temp_model_name}"
169+
" for Inference Recommender.",
170+
flush=True,
164171
)
165-
print(f"Creating temporary model with name: {self.temp_model_name}"
166-
" for Inference Recommender.", flush=True)
167172
self.sagemaker_session.create_model(**create_model_args)
168173
print("Temporary model created. Start to run Inference Recommender...", flush=True)
169174

@@ -195,8 +200,11 @@ def right_size(
195200
)
196201

197202
if self.temp_model_name is not None:
198-
print(f"Deleting temporary model with name: {self.temp_model_name} "
199-
"for Inference Recommender.", flush=True)
203+
print(
204+
f"Deleting temporary model with name: {self.temp_model_name} "
205+
"for Inference Recommender.",
206+
flush=True,
207+
)
200208
self.sagemaker_session.delete_model(self.temp_model_name)
201209
self.temp_model_name = None
202210
print("Delete complete.")

src/sagemaker/session.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4974,12 +4974,15 @@ def create_inference_recommendations_job(
49744974
"""
49754975

49764976
if model_name is None and model_package_version_arn is None:
4977-
raise ValueError("Missing model_name and model_package_version_arn,"
4978-
" please provide one of them.")
4977+
raise ValueError(
4978+
"Missing model_name and model_package_version_arn," " please provide one of them."
4979+
)
49794980

49804981
if model_name is not None and model_package_version_arn is not None:
4981-
raise ValueError("Please provide either model_name or model_package_version_arn"
4982-
" should be provided, not both.")
4982+
raise ValueError(
4983+
"Please provide either model_name or model_package_version_arn"
4984+
" should be provided, not both."
4985+
)
49834986

49844987
if not job_name:
49854988
unique_tail = uuid.uuid4()

tests/integ/test_inference_recommender.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,7 @@ def default_right_sized_unregistered_model(sagemaker_session, cpu_instance_type)
184184
ir_job_name,
185185
)
186186
except Exception:
187-
sagemaker_session.delete_model(
188-
ModelName=sklearn_model.temp_model_name
189-
)
187+
sagemaker_session.delete_model(ModelName=sklearn_model.temp_model_name)
190188

191189

192190
@pytest.fixture(scope="module")
@@ -239,9 +237,7 @@ def advanced_right_sized_unregistered_model(sagemaker_session, cpu_instance_type
239237
)
240238

241239
except Exception:
242-
sagemaker_session.delete_model(
243-
ModelName=sklearn_model.temp_model_name
244-
)
240+
sagemaker_session.delete_model(ModelName=sklearn_model.temp_model_name)
245241

246242

247243
@pytest.mark.slow_test

tests/unit/sagemaker/inference_recommender/test_inference_recommender_mixin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ def test_right_size_default_with_model_name_successful(sagemaker_session, model)
193193
container_defs=None,
194194
primary_container={},
195195
vpc_config=None,
196-
enable_network_isolation=False
196+
enable_network_isolation=False,
197197
)
198198

199199
# assert that the create api has been called with default parameters with model name

tests/unit/test_session.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3284,7 +3284,9 @@ def create_inference_recommendations_job_advanced_happy_response():
32843284

32853285

32863286
def create_inference_recommendations_job_advanced_model_name_happy_response():
3287-
base_advanced_job_response = create_inference_recommendations_job_default_model_name_happy_response()
3287+
base_advanced_job_response = (
3288+
create_inference_recommendations_job_default_model_name_happy_response()
3289+
)
32883290

32893291
base_advanced_job_response["JobName"] = IR_JOB_NAME
32903292
base_advanced_job_response["JobType"] = IR_ADVANCED_JOB
@@ -3394,7 +3396,7 @@ def test_create_inference_recommendations_job_advanced_model_name_happy(sagemake
33943396
def test_create_inference_recommendations_job_missing_model_name_and_pkg(sagemaker_session):
33953397
with pytest.raises(
33963398
ValueError,
3397-
match="Missing model_name and model_package_version_arn, please provide one of them."
3399+
match="Missing model_name and model_package_version_arn, please provide one of them.",
33983400
):
33993401
sagemaker_session.create_inference_recommendations_job(
34003402
role=IR_ROLE_ARN,
@@ -3413,7 +3415,7 @@ def test_create_inference_recommendations_job_missing_model_name_and_pkg(sagemak
34133415
def test_create_inference_recommendations_job_provided_model_name_and_pkg(sagemaker_session):
34143416
with pytest.raises(
34153417
ValueError,
3416-
match="Please provide either model_name or model_package_version_arn should be provided, not both."
3418+
match="Please provide either model_name or model_package_version_arn should be provided, not both.",
34173419
):
34183420
sagemaker_session.create_inference_recommendations_job(
34193421
role=IR_ROLE_ARN,

0 commit comments

Comments
 (0)