Skip to content

Commit 0f77d10

Browse files
author
Chuyang Deng
committed
Modify timeout class, README, CHANGELOG and model none check in session and transformer.
1 parent 56011f6 commit 0f77d10

File tree

4 files changed

+2
-56
lines changed

4 files changed

+2
-56
lines changed

src/sagemaker/session.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -796,12 +796,8 @@ def delete_model(self, model_name):
796796
model_name (str): Name of the Amazon SageMaker model to delete.
797797
798798
"""
799-
try:
800-
self.sagemaker_client.describe_model(ModelName=model_name)
801-
LOGGER.info('Deleting model with name: {}'.format(model_name))
802-
self.sagemaker_client.delete_model(ModelName=model_name)
803-
except Exception:
804-
raise ValueError('The Sagemaker model must be deployed first before attempting to delete.')
799+
LOGGER.info('Deleting model with name: {}'.format(model_name))
800+
self.sagemaker_client.delete_model(ModelName=model_name)
805801

806802
def wait_for_job(self, job, poll=5):
807803
"""Wait for an Amazon SageMaker training job to complete.

src/sagemaker/transformer.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ def __init__(self, model_name, instance_count, instance_type, strategy=None, ass
5252
using the default AWS configuration chain.
5353
volume_kms_key (str): Optional. KMS key ID for encrypting the volume attached to the ML
5454
compute instance (default: None).
55-
model (sagemaker.model.Model): A SageMaker Model object, used for SageMaker Model interactions
56-
(default: None). If not specified, model object related activities will fail.
5755
"""
5856
self.model_name = model_name
5957
self.strategy = strategy

tests/integ/timeout.py

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -98,53 +98,19 @@ def timeout_and_delete_model_with_transformer(transformer, sagemaker_session, se
9898
try:
9999
transformer.delete_model()
100100
LOGGER.info('deleted SageMaker model {}'.format(transformer.model_name))
101-
<<<<<<< HEAD
102101

103102
_show_logs(transformer.model_name, 'Models', sagemaker_session)
104103
if no_errors:
105104
_cleanup_logs(transformer.model_name, 'Models', sagemaker_session)
106-
=======
107-
if no_errors:
108-
_cleanup_model_logs(transformer.model_name, sagemaker_session)
109-
>>>>>>> 334a0d6... Modify some functions, tests and update docs.
110105
return
111106
except ClientError as ce:
112107
if ce.response['Error']['Code'] == 'ValidationException':
113108
pass
114109
sleep(10)
115110

116111

117-
<<<<<<< HEAD
118112
def _show_logs(resource_name, resource_type, sagemaker_session):
119113
log_group = '/aws/sagemaker/{}/{}'.format(resource_type, resource_name)
120-
=======
121-
def _show_model_logs(model_name, sagemaker_session):
122-
log_group = '/aws/sagemaker/Models/{}'.format(model_name)
123-
try:
124-
LOGGER.info('cloudwatch logs for log group {}'.format(log_group))
125-
logs = AWSLogs(log_group_name=log_group, log_stream_name='ALL', start='1d',
126-
aws_region=sagemaker_session.boto_session.region_name)
127-
logs.list_logs()
128-
except Exception:
129-
LOGGER.exception('Failure occurred while listing cloudwatch log group %s. Swallowing exception but printing '
130-
'stacktrace for debugging.', log_group)
131-
132-
133-
def _cleanup_model_logs(model_name, sagemaker_session):
134-
log_group = '/aws/sagemaker/Models/{}'.format(model_name)
135-
try:
136-
LOGGER.info('deleting cloudwatch log group {}:'.format(log_group))
137-
cwl_client = sagemaker_session.boto_session.client('logs')
138-
cwl_client.delete_log_group(logGroupName=log_group)
139-
LOGGER.info('deleted cloudwatch log group: {}'.format(log_group))
140-
except Exception:
141-
LOGGER.exception('Failure occurred while cleaning up cloudwatch log group %s. '
142-
'Swallowing exception but printing stacktrace for debugging.', log_group)
143-
144-
145-
def _show_endpoint_logs(endpoint_name, sagemaker_session):
146-
log_group = '/aws/sagemaker/Endpoints/{}'.format(endpoint_name)
147-
>>>>>>> 334a0d6... Modify some functions, tests and update docs.
148114
try:
149115
# print out logs before deletion for debuggability
150116
LOGGER.info('cloudwatch logs for log group {}:'.format(log_group))

tests/unit/test_model.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -345,23 +345,9 @@ def test_model_delete_model(sagemaker_session, tmpdir):
345345
model.delete_model()
346346

347347
sagemaker_session.delete_model.assert_called_with(model.name)
348-
<<<<<<< HEAD
349-
<<<<<<< HEAD
350348

351349

352350
def test_delete_non_deployed_model(sagemaker_session):
353351
model = DummyFrameworkModel(sagemaker_session)
354352
with pytest.raises(ValueError, match='The SageMaker model must be created first before attempting to delete.'):
355353
model.delete_model()
356-
=======
357-
>>>>>>> 45e5c07... Add new APIs to predictor to delete endpoint and endpoint config, and transformer to delete model.
358-
=======
359-
360-
361-
@patch('sagemaker.fw_utils.tar_and_upload_dir', MagicMock())
362-
@patch('time.strftime', MagicMock(return_value=TIMESTAMP))
363-
def test_delete_non_deployed_model(sagemaker_session, tmpdir):
364-
model = DummyFrameworkModel(sagemaker_session, source_dir=str(tmpdir))
365-
with pytest.raises(ValueError, match='The SageMaker model must be deployed first before attempting to delete.'):
366-
model.delete_model()
367-
>>>>>>> 334a0d6... Modify some functions, tests and update docs.

0 commit comments

Comments
 (0)