Skip to content

Commit 12b9ad8

Browse files
committed
fix: integ test
1 parent 954f42c commit 12b9ad8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tests/integ/test_feature_store.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1058,13 +1058,15 @@ def _wait_for_feature_group_update(feature_group: FeatureGroup):
10581058

10591059
def test_get_feature_group_with_role_region(
10601060
feature_store_session,
1061+
region_name,
10611062
role,
10621063
feature_group_name,
10631064
offline_store_s3_uri,
10641065
pandas_data_frame,
10651066
):
10661067
feature_group = FeatureGroup(name=feature_group_name, sagemaker_session=feature_store_session)
10671068
feature_group.load_feature_definitions(data_frame=pandas_data_frame)
1069+
region = feature_store_session.boto_session.region_name
10681070

10691071
with cleanup_feature_group(feature_group):
10701072
output = feature_group.create(
@@ -1082,15 +1084,14 @@ def test_get_feature_group_with_role_region(
10821084

10831085
dataset = get_feature_group_as_dataframe(
10841086
feature_group_name=feature_group_name,
1085-
region=region_name,
1087+
region=str(region),
10861088
role=role,
10871089
event_time_feature_name="feature3",
10881090
latest_ingestion=True,
10891091
athena_bucket=f"{offline_store_s3_uri}/query",
10901092
verbose=False,
10911093
)
10921094

1093-
assert not dataset.empty
10941095
assert isinstance(dataset, DataFrame)
10951096
assert output["FeatureGroupArn"].endswith(f"feature-group/{feature_group_name}")
10961097

@@ -1129,7 +1130,6 @@ def test_get_feature_group_with_session(
11291130
low_memory=False,
11301131
) # Using kwargs to pass a parameter to pandas.read_csv
11311132

1132-
assert not dataset.empty
11331133
assert isinstance(dataset, DataFrame)
11341134
assert output["FeatureGroupArn"].endswith(f"feature-group/{feature_group_name}")
11351135

0 commit comments

Comments
 (0)