Skip to content

Commit 15b2bd5

Browse files
committed
chore: improve spec field name
1 parent 20b06f2 commit 15b2bd5

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

src/sagemaker/jumpstart/types.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -730,7 +730,7 @@ class JumpStartModelSpecs(JumpStartDataHolderType):
730730
"training_dependencies",
731731
"training_vulnerabilities",
732732
"deprecated",
733-
"info_message",
733+
"usage_info_message",
734734
"deprecated_message",
735735
"deprecate_warn_message",
736736
"default_inference_instance_type",
@@ -802,7 +802,7 @@ def from_json(self, json_obj: Dict[str, Any]) -> None:
802802
self.deprecated: bool = bool(json_obj["deprecated"])
803803
self.deprecated_message: Optional[str] = json_obj.get("deprecated_message")
804804
self.deprecate_warn_message: Optional[str] = json_obj.get("deprecate_warn_message")
805-
self.info_message: Optional[str] = json_obj.get("info_message")
805+
self.usage_info_message: Optional[str] = json_obj.get("usage_info_message")
806806
self.default_inference_instance_type: Optional[str] = json_obj.get(
807807
"default_inference_instance_type"
808808
)

src/sagemaker/jumpstart/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -511,8 +511,8 @@ def emit_logs_based_on_model_specs(
511511
if model_specs.deprecate_warn_message:
512512
constants.JUMPSTART_LOGGER.warning(model_specs.deprecate_warn_message)
513513

514-
if model_specs.info_message:
515-
constants.JUMPSTART_LOGGER.info(model_specs.info_message)
514+
if model_specs.usage_info_message:
515+
constants.JUMPSTART_LOGGER.info(model_specs.usage_info_message)
516516

517517
if model_specs.inference_vulnerable or model_specs.training_vulnerable:
518518
constants.JUMPSTART_LOGGER.warning(

tests/unit/sagemaker/jumpstart/constants.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6221,7 +6221,7 @@
62216221
"ml.c5.2xlarge",
62226222
],
62236223
"hosting_use_script_uri": True,
6224-
"info_message": None,
6224+
"usage_info_message": None,
62256225
"metrics": [{"Regex": "val_accuracy: ([0-9\\.]+)", "Name": "pytorch-ic:val-accuracy"}],
62266226
"model_kwargs": {"some-model-kwarg-key": "some-model-kwarg-value"},
62276227
"deploy_kwargs": {"some-model-deploy-kwarg-key": "some-model-deploy-kwarg-value"},

tests/unit/sagemaker/jumpstart/test_utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1034,20 +1034,20 @@ def make_deprecated_warning_message_spec(*largs, **kwargs):
10341034

10351035

10361036
@patch("sagemaker.jumpstart.utils.accessors.JumpStartModelsAccessor._get_manifest")
1037-
def test_jumpstart_info_message(mock_get_manifest):
1037+
def test_jumpstart_usage_info_message(mock_get_manifest):
10381038
mock_get_manifest.return_value = []
10391039

1040-
info_message = "This model might change your life."
1040+
usage_info_message = "This model might change your life."
10411041

10421042
def make_info_spec(*largs, **kwargs):
10431043
spec = get_spec_from_base_spec(model_id="pytorch-eqa-bert-base-cased", version="*")
1044-
spec.info_message = info_message
1044+
spec.usage_info_message = usage_info_message
10451045
return spec
10461046

10471047
with patch("logging.Logger.info") as mocked_info_log:
10481048
utils.emit_logs_based_on_model_specs(make_info_spec(), "us-west-2", MOCK_CLIENT)
10491049

1050-
mocked_info_log.assert_called_with(info_message)
1050+
mocked_info_log.assert_called_with(usage_info_message)
10511051

10521052

10531053
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")

0 commit comments

Comments
 (0)