Skip to content

Commit 1729454

Browse files
authored
Merge branch 'master' into propagate-vpc-tags-to-repack
2 parents f1d9e49 + da08405 commit 1729454

File tree

7 files changed

+39
-16
lines changed

7 files changed

+39
-16
lines changed

CHANGELOG.md

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,24 @@
11
# Changelog
22

3+
## v2.55.0 (2021-08-25)
4+
5+
### Features
6+
7+
* Add information of Amazon-provided analysis image used by Mo…
8+
9+
### Bug Fixes and Other Changes
10+
11+
* Update Changelog to fix release
12+
* Fixing the order of populating container list
13+
* pass network isolation config to pipelineModel
14+
* Deference symbolic link when create tar file
15+
* multiprocess issue in feature_group.py
16+
* deprecate tag logic on Association
17+
18+
### Documentation Changes
19+
20+
* add dataset_definition to processing page
21+
322
## v2.54.0 (2021-08-16)
423

524
### Features
@@ -8,7 +27,7 @@
827

928
### Bug Fixes and Other Changes
1029

11-
* issue #2253 where Processing job in Local mode would call Describe
30+
* issue #2253 where Processing job in Local mode would call Describe API
1231

1332
## v2.53.0 (2021-08-12)
1433

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.54.1.dev0
1+
2.55.1.dev0

doc/api/utility/inputs.rst

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,8 @@ Inputs
55
:members:
66
:undoc-members:
77
:show-inheritance:
8-
:noindex:
8+
9+
.. automodule:: sagemaker.dataset_definition.inputs
10+
:members:
11+
:undoc-members:
12+
:show-inheritance:

src/sagemaker/dataset_definition/inputs.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class RedshiftDatasetDefinition(ApiObject):
2727
2828
With this input, SQL queries will be executed using Redshift to generate datasets to S3.
2929
30-
Attributes:
30+
Parameters:
3131
cluster_id (str): The Redshift cluster Identifier.
3232
database (str): The name of the Redshift database used in Redshift query execution.
3333
db_user (str): The database user name used in Redshift query execution.
@@ -60,7 +60,7 @@ class AthenaDatasetDefinition(ApiObject):
6060
6161
With this input, SQL queries will be executed using Athena to generate datasets to S3.
6262
63-
Attributes:
63+
Parameters:
6464
catalog (str): The name of the data catalog used in Athena query execution.
6565
database (str): The name of the database used in the Athena query execution.
6666
query_string (str): The SQL query statements, to be executed.
@@ -87,7 +87,7 @@ class AthenaDatasetDefinition(ApiObject):
8787
class DatasetDefinition(ApiObject):
8888
"""DatasetDefinition input.
8989
90-
Attributes:
90+
Parameters:
9191
data_distribution_type (str): Whether the generated dataset is FullyReplicated or
9292
ShardedByS3Key (default).
9393
input_mode (str): Whether to use File or Pipe input mode. In File (default) mode, Amazon
@@ -98,9 +98,8 @@ class DatasetDefinition(ApiObject):
9898
local_path (str): The local path where you want Amazon SageMaker to download the Dataset
9999
Definition inputs to run a processing job. LocalPath is an absolute path to the input
100100
data. This is a required parameter when `AppManaged` is False (default).
101-
redshift_dataset_definition
102-
(:class:`~sagemaker.dataset_definition.inputs.RedshiftDatasetDefinition`): Redshift
103-
dataset definition.
101+
redshift_dataset_definition (:class:`~sagemaker.dataset_definition.inputs.RedshiftDatasetDefinition`):
102+
Configuration for Redshift Dataset Definition input.
104103
athena_dataset_definition (:class:`~sagemaker.dataset_definition.inputs.AthenaDatasetDefinition`):
105104
Configuration for Athena Dataset Definition input.
106105
"""
@@ -126,7 +125,7 @@ class S3Input(ApiObject):
126125
S3 list operations are not strongly consistent.
127126
Use ManifestFile if strong consistency is required.
128127
129-
Attributes:
128+
Parameters:
130129
s3_uri (str): the path to a specific S3 object or a S3 prefix
131130
local_path (str): the path to a local directory. If not provided, skips data download
132131
by SageMaker platform.

src/sagemaker/inputs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ def __init__(self, seed):
127127
class CreateModelInput(object):
128128
"""A class containing parameters which can be used to create a SageMaker Model
129129
130-
Attributes:
130+
Parameters:
131131
instance_type (str): type or EC2 instance will be used for model deployment.
132132
accelerator_type (str): elastic inference accelerator type.
133133
"""

src/sagemaker/model.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1097,6 +1097,8 @@ def _upload_code(self, key_prefix, repack=False):
10971097

10981098
def _framework_env_vars(self):
10991099
"""Placeholder docstring"""
1100+
script_name = None
1101+
dir_name = None
11001102
if self.uploaded_code:
11011103
script_name = self.uploaded_code.script_name
11021104
if self.enable_network_isolation():
@@ -1105,10 +1107,8 @@ def _framework_env_vars(self):
11051107
dir_name = self.uploaded_code.s3_prefix
11061108
elif self.entry_point is not None:
11071109
script_name = self.entry_point
1108-
dir_name = "file://" + self.source_dir
1109-
else:
1110-
script_name = None
1111-
dir_name = None
1110+
if self.source_dir is not None:
1111+
dir_name = "file://" + self.source_dir
11121112

11131113
return {
11141114
SCRIPT_PARAM_NAME.upper(): script_name or str(),

tests/scripts/run-notebook-test.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,5 @@ echo "set SAGEMAKER_ROLE_ARN=$SAGEMAKER_ROLE_ARN"
3030
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_moving_from_framework_mode_to_script_mode/tensorflow_moving_from_framework_mode_to_script_mode.ipynb \
3131
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_script_mode_pipe_mode/tensorflow_script_mode_pipe_mode.ipynb \
3232
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_script_mode_quickstart/tensorflow_script_mode_quickstart.ipynb \
33-
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_serving_using_elastic_inference_with_your_own_model/tensorflow_serving_pretrained_model_elastic_inference.ipynb
33+
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_serving_using_elastic_inference_with_your_own_model/tensorflow_serving_pretrained_model_elastic_inference.ipynb \
34+
./amazon-sagemaker-examples/sagemaker-pipelines/tabular/abalone_build_train_deploy/sagemaker-pipelines-preprocess-train-evaluate-batch-transform.ipynb

0 commit comments

Comments
 (0)