Skip to content

Commit 18062e1

Browse files
committed
fix: include sparkml 2.4 in image uri config properly
1 parent e718f33 commit 18062e1

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

src/sagemaker/image_uri_config/sparkml-serving.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
"us-west-2": "246618743249"
3030
},
3131
"repository": "sagemaker-sparkml-serving"
32-
}
33-
},
32+
},
3433
"2.4": {
3534
"registries": {
3635
"af-south-1": "510948584623",
@@ -60,4 +59,5 @@
6059
},
6160
"repository": "sagemaker-sparkml-serving"
6261
}
62+
}
6363
}

tests/unit/sagemaker/image_uris/test_sparkml.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
# language governing permissions and limitations under the License.
1313
from __future__ import absolute_import
1414

15+
import pytest
16+
1517
from sagemaker import image_uris
1618
from tests.unit.sagemaker.image_uris import expected_uris, regions
1719

@@ -41,14 +43,15 @@
4143
"us-west-1": "746614075791",
4244
"us-west-2": "246618743249",
4345
}
44-
VERSION = "2.2"
46+
VERSIONS = ["2.2", "2.4"]
4547

4648

47-
def test_sparkml():
49+
@pytest.mark.parametrize("version", VERSIONS)
50+
def test_sparkml(version):
4851
for region in regions.regions():
49-
uri = image_uris.retrieve("sparkml-serving", region=region, version=VERSION)
52+
uri = image_uris.retrieve("sparkml-serving", region=region, version=version)
5053

5154
expected = expected_uris.algo_uri(
52-
"sagemaker-sparkml-serving", ACCOUNTS[region], region, version=VERSION
55+
"sagemaker-sparkml-serving", ACCOUNTS[region], region, version=version
5356
)
5457
assert expected == uri

0 commit comments

Comments
 (0)