Skip to content

Commit 32199b6

Browse files
committed
fix: convert network_config in processing_config to dict
1 parent 189579f commit 32199b6

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

src/sagemaker/workflow/airflow.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1144,7 +1144,7 @@ def processing_config(
11441144
config["Environment"] = processor.env
11451145

11461146
if processor.network_config is not None:
1147-
config["NetworkConfig"] = processor.network_config
1147+
config["NetworkConfig"] = processor.network_config._to_request_dict()
11481148

11491149
processing_resources = sagemaker.processing.ProcessingJob.prepare_processing_resources(
11501150
instance_count=processor.instance_count,

tests/unit/test_airflow.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
from mock import Mock, MagicMock, patch
1717

1818
from sagemaker import chainer, estimator, model, mxnet, tensorflow, transformer, tuner, processing
19+
from sagemaker.network import NetworkConfig
1920
from sagemaker.processing import ProcessingInput, ProcessingOutput
2021
from sagemaker.workflow import airflow
2122
from sagemaker.amazon import amazon_estimator
@@ -1598,6 +1599,13 @@ def test_deploy_config_from_amazon_alg_estimator(sagemaker_session):
15981599
@patch("sagemaker.utils.sagemaker_timestamp", MagicMock(return_value=TIME_STAMP))
15991600
def test_processing_config(sagemaker_session):
16001601

1602+
network_config = NetworkConfig(
1603+
encrypt_inter_container_traffic=False,
1604+
enable_network_isolation=True,
1605+
security_group_ids=["sg1"],
1606+
subnets=["subnet1"],
1607+
)
1608+
16011609
processor = processing.Processor(
16021610
role="arn:aws:iam::0122345678910:role/SageMakerPowerUser",
16031611
image_uri="{{ image_uri }}",
@@ -1612,6 +1620,7 @@ def test_processing_config(sagemaker_session):
16121620
sagemaker_session=sagemaker_session,
16131621
tags=[{"{{ key }}": "{{ value }}"}],
16141622
env={"{{ key }}": "{{ value }}"},
1623+
network_config=network_config,
16151624
)
16161625

16171626
outputs = [
@@ -1699,5 +1708,10 @@ def test_processing_config(sagemaker_session):
16991708
"RoleArn": "arn:aws:iam::0122345678910:role/SageMakerPowerUser",
17001709
"StoppingCondition": {"MaxRuntimeInSeconds": 3600},
17011710
"Tags": [{"{{ key }}": "{{ value }}"}],
1711+
"NetworkConfig": {
1712+
"EnableInterContainerTrafficEncryption": False,
1713+
"EnableNetworkIsolation": True,
1714+
"VpcConfig": {"SecurityGroupIds": ["sg1"], "Subnets": ["subnet1"]},
1715+
},
17021716
}
17031717
assert config == expected_config

0 commit comments

Comments
 (0)