Skip to content

Commit 34f2882

Browse files
authored
change: update PR template with items about tests, regional endpoints, and API docs (#1162)
1 parent d3b37bb commit 34f2882

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,17 @@
22

33
*Description of changes:*
44

5+
*Testing done:*
6+
57
## Merge Checklist
68

79
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request._
810

911
- [ ] I have read the [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md) doc
1012
- [ ] I used the commit message format described in [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md#committing-your-change)
13+
- [ ] I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
1114
- [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
12-
- [ ] I have updated any necessary [documentation](https://github.com/aws/sagemaker-python-sdk/blob/master/README.rst) (if appropriate)
15+
- [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)
16+
- [ ] I have updated any necessary documentation, including [READMEs](https://github.com/aws/sagemaker-python-sdk/blob/master/README.rst) and [API docs](https://github.com/aws/sagemaker-python-sdk/tree/master/doc) (if appropriate)
1317

1418
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

0 commit comments

Comments
 (0)