Skip to content

Commit 4b15667

Browse files
author
Ignacio Quintero
committed
Change the way we ignore coverage.
For the integration tests we are not interested in holding the 90% coverage bar. Since we run them in isolation it doesn't report coverage correctly and even setting a low threshold will fail the build. If we set IGNORE_COVERAGE=- then the exit code of coverage result will be ignored.
1 parent 8a69d47 commit 4b15667

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

tox.ini

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,11 @@ passenv =
3232
AWS_ACCESS_KEY_ID
3333
AWS_SECRET_ACCESS_KEY
3434
AWS_SESSION_TOKEN
35-
COVERAGE_THRESHOLD
3635
# {posargs} can be passed in by additional arguments specified when invoking tox.
3736
# Can be used to specify which tests to run, e.g.: tox -- -s
3837
commands =
3938
coverage run --source sagemaker -m py.test {posargs}
40-
coverage report --fail-under={env:COVERAGE_THRESHOLD:90} --omit */tensorflow/tensorflow_serving/*
39+
{env:IGNORE_COVERAGE:} coverage report --fail-under=90 --omit */tensorflow/tensorflow_serving/*
4140
deps =
4241
pytest
4342
pytest-cov

0 commit comments

Comments
 (0)