Rename destroy method

Author: bveeramani

src/sagemaker/model.py

@@ -52,7 +52,7 @@ def deploy(self, *args, **kwargs) -> PredictorBase:
         """Deploy this model to a compute service."""
 
     @abc.abstractmethod
-    def destroy(self, *args, **kwargs) -> None:
+    def delete_model(self, *args, **kwargs) -> None:
         """Destroy resources associated with this model."""
 
 
@@ -823,8 +823,6 @@ def delete_model(self):
             )
         self.sagemaker_session.delete_model(self.name)
 
-    destroy = delete_model
-
 
 SCRIPT_PARAM_NAME = "sagemaker_program"
 DIR_PARAM_NAME = "sagemaker_submit_directory"

src/sagemaker/predictor.py

@@ -62,7 +62,7 @@ def predict(self, *args, **kwargs) -> Any:
         """Perform inference on the provided data and return a prediction."""
 
     @abc.abstractmethod
-    def destroy(self, *args, **kwargs) -> None:
+    def delete_endpoint(self, *args, **kwargs) -> None:
         """Destroy resources associated with this predictor."""
 
     @property
@@ -330,8 +330,6 @@ def delete_endpoint(self, delete_endpoint_config=True):
 
         self.sagemaker_session.delete_endpoint(self.endpoint_name)
 
-    destroy = delete_endpoint
-
     def delete_model(self):
         """Deletes the Amazon SageMaker models backing this predictor."""
         request_failed = False

src/sagemaker/serverless/model.py

@@ -82,7 +82,7 @@ def deploy(
 
         return LambdaPredictor(function_name, client=self._client)
 
-    def destroy(self) -> None:
+    def delete_model(self) -> None:
         """Destroy resources associated with this model.
 
         This method does not delete the image specified in the constructor. As

src/sagemaker/serverless/predictor.py

@@ -61,7 +61,7 @@ def predict(self, data: dict) -> dict:
             response["ResponseMetadata"]["HTTPHeaders"]["content-type"],
         )
 
-    def destroy(self) -> None:
+    def delete_endpoint(self) -> None:
         """Destroy the Lambda function specified in the constructor."""
         self._client.delete_function(FunctionName=self._function_name)
 

tests/unit/sagemaker/serverless/test_model.py

@@ -49,4 +49,4 @@ def test_deploy(mock_client, wait):
 
 def test_destroy():
     model = LambdaModel(IMAGE_URI, ROLE, client=mock_client)
-    model.destroy()  # NOTE: This method is a no-op.
+    model.delete_model()  # NOTE: This method is a no-op.

tests/unit/sagemaker/serverless/test_predictor.py

@@ -48,7 +48,7 @@ def test_predict(mock_client):
 def test_destroy(mock_client):
     predictor = LambdaPredictor(FUNCTION_NAME, client=mock_client)
 
-    predictor.destroy()
+    predictor.delete_endpoint()
 
     mock_client.delete_function.assert_called_once()
     _, kwargs = mock_client.delete_function.call_args