Skip to content

Commit 5583235

Browse files
authored
change: include more notebook tests, logger to warn (#1953)
1 parent 0c8fa82 commit 5583235

File tree

3 files changed

+16
-6
lines changed

3 files changed

+16
-6
lines changed

src/sagemaker/deprecations.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@
1717
import warnings
1818

1919
logging.captureWarnings(True)
20+
logger = logging.getLogger(__name__)
21+
22+
V2_URL = "https://sagemaker.readthedocs.io/en/stable/v2.html"
2023

2124

2225
def _warn(msg):
@@ -25,12 +28,9 @@ def _warn(msg):
2528
Args:
2629
phrase: The phrase to include in the warning.
2730
"""
28-
warnings.warn(
29-
f"{msg} in sagemaker>=2.\n"
30-
"See: https://sagemaker.readthedocs.io/en/stable/v2.html for details.",
31-
DeprecationWarning,
32-
stacklevel=2,
33-
)
31+
full_msg = f"{msg} in sagemaker>=2.\nSee: {V2_URL} for details."
32+
warnings.warn(full_msg, DeprecationWarning, stacklevel=2)
33+
logger.warning(full_msg)
3434

3535

3636
def removed_warning(phrase):

src/sagemaker/predictor.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
deprecated_serialize,
2020
removed_kwargs,
2121
renamed_kwargs,
22+
renamed_warning,
2223
)
2324
from sagemaker.deserializers import ( # noqa: F401 # pylint: disable=unused-import
2425
BytesDeserializer,
@@ -412,6 +413,12 @@ def accept(self):
412413
"""The content type(s) that are expected from the inference endpoint."""
413414
return self.deserializer.ACCEPT
414415

416+
@property
417+
def endpoint(self):
418+
"""Deprecated attribute. Please use endpoint_name."""
419+
renamed_warning("The endpoint attribute")
420+
return self.endpoint_name
421+
415422

416423
csv_serializer = deprecated_serialize(CSVSerializer(), "csv_serializer")
417424
json_serializer = deprecated_serialize(JSONSerializer(), "json_serializer")

tests/scripts/run-notebook-test.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,15 @@ echo "set SAGEMAKER_ROLE_ARN=$SAGEMAKER_ROLE_ARN"
2222
./amazon-sagemaker-examples/advanced_functionality/kmeans_bring_your_own_model/kmeans_bring_your_own_model.ipynb \
2323
./amazon-sagemaker-examples/advanced_functionality/tensorflow_iris_byom/tensorflow_BYOM_iris.ipynb \
2424
./amazon-sagemaker-examples/sagemaker-python-sdk/1P_kmeans_highlevel/kmeans_mnist.ipynb \
25+
./amazon-sagemaker-examples/sagemaker-python-sdk/1P_kmeans_lowlevel/kmeans_mnist_lowlevel.ipynb \
2526
./amazon-sagemaker-examples/sagemaker-python-sdk/managed_spot_training_mxnet/managed_spot_training_mxnet.ipynb \
27+
./amazon-sagemaker-examples/sagemaker-python-sdk/mxnet_gluon_sentiment/mxnet_sentiment_analysis_with_gluon.ipynb \
2628
./amazon-sagemaker-examples/sagemaker-python-sdk/mxnet_onnx_eia/mxnet_onnx_eia.ipynb \
2729
./amazon-sagemaker-examples/sagemaker-python-sdk/mxnet_onnx_export/mxnet_onnx_export.ipynb \
2830
./amazon-sagemaker-examples/sagemaker-python-sdk/pytorch_cnn_cifar10/pytorch_local_mode_cifar10.ipynb \
2931
./amazon-sagemaker-examples/sagemaker-python-sdk/scikit_learn_randomforest/Sklearn_on_SageMaker_end2end.ipynb \
3032
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_moving_from_framework_mode_to_script_mode/tensorflow_moving_from_framework_mode_to_script_mode.ipynb \
3133
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_script_mode_pipe_mode/tensorflow_script_mode_pipe_mode.ipynb \
34+
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_script_mode_quickstart/tensorflow_script_mode_quickstart.ipynb \
3235
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_script_mode_using_shell_commands/tensorflow_script_mode_using_shell_commands.ipynb \
3336
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_serving_using_elastic_inference_with_your_own_model/tensorflow_serving_pretrained_model_elastic_inference.ipynb

0 commit comments

Comments
 (0)