Skip to content

Commit 5bb6dcc

Browse files
author
Balaji Veeramani
committed
Remove LegacySerializer and LegacyDeserializer
1 parent 6b76093 commit 5bb6dcc

File tree

1 file changed

+0
-93
lines changed

1 file changed

+0
-93
lines changed

src/sagemaker/predictor.py

Lines changed: 0 additions & 93 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@
1313
"""Placeholder docstring"""
1414
from __future__ import print_function, absolute_import
1515

16-
from sagemaker.deserializers import BaseDeserializer
1716
from sagemaker.model_monitor import DataCaptureConfig
18-
from sagemaker.serializers import BaseSerializer
1917
from sagemaker.session import production_variant, Session
2018
from sagemaker.utils import name_from_base
2119

@@ -64,11 +62,6 @@ def __init__(
6462
accept (str): The invocation's "Accept", overriding any accept from
6563
the deserializer (default: None).
6664
"""
67-
if serializer is not None and not isinstance(serializer, BaseSerializer):
68-
serializer = LegacySerializer(serializer)
69-
if deserializer is not None and not isinstance(deserializer, BaseDeserializer):
70-
deserializer = LegacyDeserializer(deserializer)
71-
7265
self.endpoint_name = endpoint_name
7366
self.sagemaker_session = sagemaker_session or Session()
7467
self.serializer = serializer
@@ -115,8 +108,6 @@ def _handle_response(self, response):
115108
"""
116109
response_body = response["Body"]
117110
if self.deserializer is not None:
118-
if not isinstance(self.deserializer, BaseDeserializer):
119-
self.deserializer = LegacyDeserializer(self.deserializer)
120111
# It's the deserializer's responsibility to close the stream
121112
return self.deserializer.deserialize(response_body, response["ContentType"])
122113
data = response_body.read()
@@ -149,8 +140,6 @@ def _create_request_args(self, data, initial_args=None, target_model=None, targe
149140
args["TargetVariant"] = target_variant
150141

151142
if self.serializer is not None:
152-
if not isinstance(self.serializer, BaseSerializer):
153-
self.serializer = LegacySerializer(self.serializer)
154143
data = self.serializer.serialize(data)
155144

156145
args["Body"] = data
@@ -403,85 +392,3 @@ def _get_model_names(self):
403392
)
404393
production_variants = endpoint_config["ProductionVariants"]
405394
return [d["ModelName"] for d in production_variants]
406-
407-
408-
class LegacySerializer(BaseSerializer):
409-
"""Wrapper that makes legacy serializers forward compatibile."""
410-
411-
def __init__(self, serializer):
412-
"""Initialize a ``LegacySerializer``.
413-
414-
Args:
415-
serializer (callable): A legacy serializer.
416-
"""
417-
self.serializer = serializer
418-
self.content_type = getattr(serializer, "content_type", None)
419-
420-
def __call__(self, *args, **kwargs):
421-
"""Wraps the call method of the legacy serializer.
422-
423-
Args:
424-
data (object): Data to be serialized.
425-
426-
Returns:
427-
object: Serialized data used for a request.
428-
"""
429-
return self.serializer(*args, **kwargs)
430-
431-
def serialize(self, data):
432-
"""Wraps the call method of the legacy serializer.
433-
434-
Args:
435-
data (object): Data to be serialized.
436-
437-
Returns:
438-
object: Serialized data used for a request.
439-
"""
440-
return self.serializer(data)
441-
442-
@property
443-
def CONTENT_TYPE(self):
444-
"""The MIME type of the data sent to the inference endpoint."""
445-
return self.content_type
446-
447-
448-
class LegacyDeserializer(BaseDeserializer):
449-
"""Wrapper that makes legacy deserializers forward compatibile."""
450-
451-
def __init__(self, deserializer):
452-
"""Initialize a ``LegacyDeserializer``.
453-
454-
Args:
455-
deserializer (callable): A legacy deserializer.
456-
"""
457-
self.deserializer = deserializer
458-
self.accept = getattr(deserializer, "accept", None)
459-
460-
def __call__(self, *args, **kwargs):
461-
"""Wraps the call method of the legacy deserializer.
462-
463-
Args:
464-
data (object): Data to be deserialized.
465-
content_type (str): The MIME type of the data.
466-
467-
Returns:
468-
object: The data deserialized into an object.
469-
"""
470-
return self.deserializer(*args, **kwargs)
471-
472-
def deserialize(self, data, content_type):
473-
"""Wraps the call method of the legacy deserializer.
474-
475-
Args:
476-
data (object): Data to be deserialized.
477-
content_type (str): The MIME type of the data.
478-
479-
Returns:
480-
object: The data deserialized into an object.
481-
"""
482-
return self.deserializer(data, content_type)
483-
484-
@property
485-
def ACCEPT(self):
486-
"""The content type that is expected from the inference endpoint."""
487-
return self.accept

0 commit comments

Comments
 (0)