Skip to content

Commit 68843c1

Browse files
author
Balaji Veeramani
committed
Address review comments
1 parent 9ad1fe9 commit 68843c1

File tree

2 files changed

+15
-9
lines changed

2 files changed

+15
-9
lines changed

doc/v2.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,14 @@ Please use :func:`sagemaker.predictor.Predictor.delete_endpoint` instead.
6767
Pre-instantiated Serializer and Deserializer Objects
6868
----------------------------------------------------
6969

70-
The ``csv_serializer``, ``json_serializer``, ``npy_serializer``, ``csv_deserializer``,
70+
The ``csv_serializer``, ``json_serializer``, ``npy_serializer``, ``csv_deserializer``,
7171
``json_deserializer``, and ``numpy_deserializer`` objects have been deprecated.
7272

7373
Please instantiate the objects instead.
7474

7575
+--------------------------------------------+------------------------------------------------+
7676
| v1.x | v2.0 and later |
77-
+============================================|================================================+
77+
+============================================+================================================+
7878
| ``sagemaker.predictor.csv_serializer`` | ``sagemaker.deserializers.CSVSerializer()`` |
7979
+--------------------------------------------+------------------------------------------------+
8080
| ``sagemaker.predictor.json_serializer`` | ``sagemaker.serializers.JSONSerializer()`` |

src/sagemaker/cli/compatibility/v2/modifiers/serde.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@
3737
"_NumpyDeserializer": ("sagemaker.predictor",),
3838
"_JsonDeserializer": ("sagemaker.predictor",),
3939
}
40-
OLD_CLASS_NAMES_TO_NAMESPACES.update({
41-
class_name: ("sagemaker.amazon.common",) for class_name in OLD_AMAZON_CLASS_NAMES
42-
})
40+
OLD_CLASS_NAME_TO_NAMESPACES.update(
41+
{class_name: ("sagemaker.amazon.common",) for class_name in OLD_AMAZON_CLASS_NAMES}
42+
)
4343

4444
# The values are tuples so that the object can be passed to matching.matches_any.
4545
NEW_CLASS_NAME_TO_NAMESPACES = {
@@ -151,8 +151,11 @@ def modify_node(self, node):
151151

152152
namespace_name = NEW_CLASS_NAME_TO_NAMESPACES[new_class_name][0]
153153
subpackage_name = namespace_name.split(".")[1]
154-
assert subpackage_name in {"serializers", "deserializers"}
155-
return pasta.parse("%s.%s()" % (subpackage_name, new_class_name)).body[0].value
154+
return ast.Call(
155+
func=ast.Attribute(value=ast.Name(id=subpackage_name), attr=new_class_name),
156+
args=[],
157+
keywords=[],
158+
)
156159

157160

158161
class SerdeObjectRenamer(Modifier):
@@ -203,8 +206,11 @@ def modify_node(self, node):
203206
new_class_name = OLD_OBJECT_NAME_TO_NEW_CLASS_NAME[object_name]
204207
namespace_name = NEW_CLASS_NAME_TO_NAMESPACES[new_class_name][0]
205208
subpackage_name = namespace_name[namespace_name.find(".") + 1 :]
206-
assert subpackage_name in {"serializers", "deserializers"}
207-
return pasta.parse("%s.%s()" % (subpackage_name, new_class_name)).body[0].value
209+
return ast.Call(
210+
func=ast.Attribute(value=ast.Name(id=subpackage_name), attr=new_class_name),
211+
args=[],
212+
keywords=[],
213+
)
208214

209215

210216
class SerdeImportFromPredictorRenamer(Modifier):

0 commit comments

Comments
 (0)