Skip to content

Commit 6b0b83f

Browse files
author
Chuyang Deng
committed
using the generic template for model monitor image retrieve
1 parent 021937b commit 6b0b83f

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

src/sagemaker/image_uri_config/model-monitor.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"scope": ["monitoring"],
33
"versions": {
4-
"1": {
4+
"": {
55
"registries": {
66
"eu-north-1": "895015795356",
77
"me-south-1": "607024016150",

src/sagemaker/image_uris.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121

2222
logger = logging.getLogger(__name__)
2323

24-
ECR_URI_TEMPLATE = "{registry}.dkr.{hostname}/{repository}:{tag}"
25-
MONITOR_URI_TEMPLATE = "{registry}.dkr.{hostname}/{repository}"
24+
ECR_URI_TEMPLATE = "{registry}.dkr.{hostname}/{repository}"
2625

2726

2827
def retrieve(
@@ -71,16 +70,15 @@ def retrieve(
7170

7271
repo = version_config["repository"]
7372

74-
# model-monitoring image uri does not have tags
75-
if framework == "model-monitor":
76-
return MONITOR_URI_TEMPLATE.format(registry=registry, hostname=hostname, repository=repo)
77-
7873
processor = _processor(
7974
instance_type, config.get("processors") or version_config.get("processors")
8075
)
8176
tag = _format_tag(version_config.get("tag_prefix", version), processor, py_version)
8277

83-
return ECR_URI_TEMPLATE.format(registry=registry, hostname=hostname, repository=repo, tag=tag)
78+
if tag:
79+
repo += ":{}".format(tag)
80+
81+
return ECR_URI_TEMPLATE.format(registry=registry, hostname=hostname, repository=repo)
8482

8583

8684
def _config_for_framework_and_scope(framework, image_scope, accelerator_type=None):

0 commit comments

Comments
 (0)