chore: remove unnecessary log, improve error message

Author: evakravi

src/sagemaker/jumpstart/artifacts/image_uris.py

@@ -18,7 +18,6 @@
 from sagemaker.jumpstart.constants import (
     DEFAULT_JUMPSTART_SAGEMAKER_SESSION,
     JUMPSTART_DEFAULT_REGION_NAME,
-    JUMPSTART_LOGGER,
 )
 from sagemaker.jumpstart.enums import (
     JumpStartScriptScope,
@@ -128,13 +127,11 @@ def _retrieve_image_uri(
                 return image_uri
         ecr_specs = model_specs.hosting_ecr_specs
         if ecr_specs is None:
-            raise ValueError("No value for hosting ECR specs found!")
-        JUMPSTART_LOGGER.warning(
-            "Using fallback inference ECR specs for retrieving image URI "
-            "for JumpStart model ID '%s': '%s'",
-            model_id,
-            str(ecr_specs),
-        )
+            raise ValueError(
+                f"No hosting ECR specs found for JumpStart model ID '{model_id}' with "
+                f"{instance_type} instance type in {region}. "
+                "Please try another instance type or region."
+            )
     elif image_scope == JumpStartScriptScope.TRAINING:
         training_instance_type_variants = model_specs.training_instance_type_variants
         if training_instance_type_variants:
@@ -145,13 +142,11 @@ def _retrieve_image_uri(
                 return image_uri
         ecr_specs = model_specs.training_ecr_specs
         if ecr_specs is None:
-            raise ValueError("No value for training ECR specs found!")
-        JUMPSTART_LOGGER.warning(
-            "Using fallback training ECR specs for retrieving image URI "
-            "for JumpStart model ID '%s': '%s'",
-            model_id,
-            str(ecr_specs),
-        )
+            raise ValueError(
+                f"No training ECR specs found for JumpStart model ID '{model_id}' with "
+                f"{instance_type} instance type in {region}. "
+                "Please try another instance type or region."
+            )
     if framework is not None and framework != ecr_specs.framework:
         raise ValueError(
             f"Incorrect container framework '{framework}' for JumpStart model ID '{model_id}' "

tests/unit/sagemaker/image_uris/jumpstart/test_variants.py

@@ -21,11 +21,10 @@
 from tests.unit.sagemaker.jumpstart.utils import get_special_model_spec
 
 
-@patch("sagemaker.jumpstart.artifacts.image_uris.JUMPSTART_LOGGER.warning")
 @patch("sagemaker.jumpstart.artifacts.image_uris.verify_model_region_and_return_specs")
 @patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
 def test_jumpstart_variants_image_uri(
-    patched_get_model_specs, patched_verify_model_region_and_return_specs, patched_warning_logger
+    patched_get_model_specs, patched_verify_model_region_and_return_specs
 ):
 
     patched_verify_model_region_and_return_specs.side_effect = verify_model_region_and_return_specs
@@ -44,8 +43,6 @@ def test_jumpstart_variants_image_uri(
         )
     )
 
-    patched_warning_logger.assert_not_called()
-
     assert "867930986793.dkr.us-west-2.amazonaws.com/cpu-blah" == image_uris.retrieve(
         framework=None,
         region="us-west-2",
@@ -55,10 +52,6 @@ def test_jumpstart_variants_image_uri(
         instance_type="ml.c2.xlarge",
     )
 
-    patched_warning_logger.assert_not_called()
-
-    patched_warning_logger.reset_mock()
-
     assert (
         "763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-inference:1.5.0-cpu-py3"
         == image_uris.retrieve(
@@ -71,14 +64,6 @@ def test_jumpstart_variants_image_uri(
         )
     )
 
-    patched_warning_logger.assert_called_once_with(
-        "Using fallback inference ECR specs for retrieving image URI for JumpStart model ID '%s': '%s'",
-        "variant-model",
-        "JumpStartECRSpecs: {'framework': 'pytorch', 'framework_version': '1.5.0', 'py_version': 'py3'}",
-    )
-
-    patched_warning_logger.reset_mock()
-
     with pytest.raises(ValueError):
         image_uris.retrieve(
             framework=None,
@@ -89,14 +74,6 @@ def test_jumpstart_variants_image_uri(
             instance_type="ml.c2.xlarge",
         )
 
-    patched_warning_logger.assert_called_once_with(
-        "Using fallback inference ECR specs for retrieving image URI for JumpStart model ID '%s': '%s'",
-        "variant-model",
-        "JumpStartECRSpecs: {'framework': 'pytorch', 'framework_version': '1.5.0', 'py_version': 'py3'}",
-    )
-
-    patched_warning_logger.reset_mock()
-
     assert (
         "763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:1.5.0-gpu-py3"
         == image_uris.retrieve(
@@ -108,9 +85,3 @@ def test_jumpstart_variants_image_uri(
             instance_type="ml.g4dn.2xlarge",
         )
     )
-
-    patched_warning_logger.assert_called_once_with(
-        "Using fallback training ECR specs for retrieving image URI for JumpStart model ID '%s': '%s'",
-        "variant-model",
-        "JumpStartECRSpecs: {'framework': 'pytorch', 'framework_version': '1.5.0', 'py_version': 'py3'}",
-    )