Skip to content

Commit 79efc4f

Browse files
committed
fix: logic error in version comparison
1 parent 85af72d commit 79efc4f

File tree

1 file changed

+5
-2
lines changed
  • src/sagemaker/tensorflow/training_compiler

1 file changed

+5
-2
lines changed

src/sagemaker/tensorflow/training_compiler/config.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
"""Configuration for the SageMaker Training Compiler."""
1414
from __future__ import absolute_import
1515
import logging
16-
from packaging import version
16+
from packaging.specifiers import SpecifierSet
17+
from packaging.version import Version
1718

1819
from sagemaker.training_compiler.config import TrainingCompilerConfig as BaseConfig
1920

@@ -97,7 +98,9 @@ def validate(
9798
super(TrainingCompilerConfig, cls).validate(estimator)
9899

99100
if estimator.framework_version:
100-
if version.parse(estimator.framework_version) < cls.MIN_SUPPORTED_VERSION:
101+
if Version(estimator.framework_version) in SpecifierSet(
102+
f"< {cls.MIN_SUPPORTED_VERSION}"
103+
):
101104
error_helper_string = (
102105
"SageMaker Training Compiler only supports TensorFlow version "
103106
">= {} but received {}"

0 commit comments

Comments
 (0)