Skip to content

Commit 7a2374f

Browse files
committed
Fixing the order of populating container list
1 parent 8f5b374 commit 7a2374f

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/sagemaker/workflow/step_collections.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,8 @@ def __init__(
139139
if model is not None:
140140
if isinstance(model, PipelineModel):
141141
self.model_list = model.models
142-
self.container_def_list = model.pipeline_container_def(inference_instances[0])
143142
elif isinstance(model, Model):
144143
self.model_list = [model]
145-
self.container_def_list = [model.prepare_container_def(inference_instances[0])]
146144

147145
for model_entity in self.model_list:
148146
if estimator is not None:
@@ -156,9 +154,9 @@ def __init__(
156154
entry_point = model_entity.entry_point
157155
source_dir = model_entity.source_dir
158156
dependencies = model_entity.dependencies
159-
name = model_entity.name or model_entity._framework_name
157+
model_name = model_entity.name or model_entity._framework_name
160158
repack_model_step = _RepackModelStep(
161-
name=f"{name}RepackModel",
159+
name=f"{model_name}RepackModel",
162160
depends_on=depends_on,
163161
sagemaker_session=sagemaker_session,
164162
role=role,
@@ -171,6 +169,10 @@ def __init__(
171169
model_entity.model_data = (
172170
repack_model_step.properties.ModelArtifacts.S3ModelArtifacts
173171
)
172+
if isinstance(model, PipelineModel):
173+
self.container_def_list = model.pipeline_container_def(inference_instances[0])
174+
elif isinstance(model, Model):
175+
self.container_def_list = [model.prepare_container_def(inference_instances[0])]
174176

175177
register_model_step = _RegisterModelStep(
176178
name=name,

0 commit comments

Comments
 (0)