Skip to content

Commit 7e5eb89

Browse files
committed
fix a couple more spots
1 parent cd0126b commit 7e5eb89

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

src/sagemaker/model_monitor/model_monitoring.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ def create_monitoring_schedule(
324324
max_runtime_in_seconds=self.max_runtime_in_seconds,
325325
environment=self.env,
326326
network_config=network_config_dict,
327-
role_arn=self.role,
327+
role_arn=self.sagemaker_session.expand_role(self.role),
328328
tags=self.tags,
329329
)
330330

@@ -445,7 +445,7 @@ def update_monitoring_schedule(
445445
self.network_config = network_config
446446

447447
if role is not None:
448-
self.role = self.sagemaker_session.expand_role(role)
448+
self.role = role
449449

450450
if image_uri is not None:
451451
self.image_uri = image_uri
@@ -471,7 +471,7 @@ def update_monitoring_schedule(
471471
max_runtime_in_seconds=max_runtime_in_seconds,
472472
environment=env,
473473
network_config=network_config_dict,
474-
role_arn=role,
474+
role_arn=self.sagemaker_session.expand_role(role),
475475
)
476476

477477
self._wait_for_schedule_changes_to_apply()
@@ -1285,7 +1285,7 @@ def create_monitoring_schedule(
12851285
max_runtime_in_seconds=self.max_runtime_in_seconds,
12861286
environment=normalized_env,
12871287
network_config=network_config_dict,
1288-
role_arn=self.role,
1288+
role_arn=self.sagemaker_session.expand_role(self.role),
12891289
tags=self.tags,
12901290
)
12911291

@@ -1424,7 +1424,7 @@ def update_monitoring_schedule(
14241424
network_config_dict = self.network_config._to_request_dict()
14251425

14261426
if role is not None:
1427-
self.role = self.sagemaker_session.expand_role(role)
1427+
self.role = role
14281428

14291429
self.sagemaker_session.update_monitoring_schedule(
14301430
monitoring_schedule_name=self.monitoring_schedule_name,
@@ -1442,7 +1442,7 @@ def update_monitoring_schedule(
14421442
max_runtime_in_seconds=max_runtime_in_seconds,
14431443
environment=normalized_env,
14441444
network_config=network_config_dict,
1445-
role_arn=role,
1445+
role_arn=self.sagemaker_session.expand_role(role),
14461446
)
14471447

14481448
self._wait_for_schedule_changes_to_apply()

tests/integ/test_model_monitor.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ def test_default_monitor_suggest_baseline_and_create_monitoring_schedule_with_cu
319319
== volume_kms_key
320320
)
321321
assert DEFAULT_IMAGE_SUFFIX in baselining_job_description["AppSpecification"]["ImageUri"]
322-
assert baselining_job_description["RoleArn"] == ROLE
322+
assert ROLE in baselining_job_description["RoleArn"]
323323
assert (
324324
baselining_job_description["ProcessingInputs"][0]["InputName"] == "baseline_dataset_input"
325325
)
@@ -496,7 +496,7 @@ def test_default_monitor_suggest_baseline_and_create_monitoring_schedule_without
496496
is None
497497
)
498498
assert DEFAULT_IMAGE_SUFFIX in baselining_job_description["AppSpecification"]["ImageUri"]
499-
assert baselining_job_description["RoleArn"] == ROLE
499+
assert ROLE in baselining_job_description["RoleArn"]
500500
assert (
501501
baselining_job_description["ProcessingInputs"][0]["InputName"] == "baseline_dataset_input"
502502
)
@@ -1528,7 +1528,7 @@ def test_byoc_monitor_suggest_baseline_and_create_monitoring_schedule_with_custo
15281528
== volume_kms_key
15291529
)
15301530
assert DEFAULT_IMAGE_SUFFIX in baselining_job_description["AppSpecification"]["ImageUri"]
1531-
assert baselining_job_description["RoleArn"] == ROLE
1531+
assert ROLE in baselining_job_description["RoleArn"]
15321532
assert baselining_job_description["ProcessingInputs"][0]["InputName"] == "input-1"
15331533
assert (
15341534
baselining_job_description["ProcessingOutputConfig"]["Outputs"][0]["OutputName"]
@@ -1727,7 +1727,7 @@ def test_byoc_monitor_suggest_baseline_and_create_monitoring_schedule_without_cu
17271727
is None
17281728
)
17291729
assert DEFAULT_IMAGE_SUFFIX in baselining_job_description["AppSpecification"]["ImageUri"]
1730-
assert baselining_job_description["RoleArn"] == ROLE
1730+
assert ROLE in baselining_job_description["RoleArn"]
17311731
assert baselining_job_description["ProcessingInputs"][0]["InputName"] == "input-1"
17321732
assert (
17331733
baselining_job_description["ProcessingOutputConfig"]["Outputs"][0]["OutputName"]
@@ -2185,7 +2185,7 @@ def test_byoc_monitor_attach_followed_by_baseline_and_update_monitoring_schedule
21852185
== volume_kms_key
21862186
)
21872187
assert DEFAULT_IMAGE_SUFFIX in baselining_job_description["AppSpecification"]["ImageUri"]
2188-
assert baselining_job_description["RoleArn"] == ROLE
2188+
assert ROLE in baselining_job_description["RoleArn"]
21892189
assert baselining_job_description["ProcessingInputs"][0]["InputName"] == "input-1"
21902190
assert (
21912191
baselining_job_description["ProcessingOutputConfig"]["Outputs"][0]["OutputName"]

0 commit comments

Comments
 (0)