Skip to content

Commit 7f515c3

Browse files
committed
make the condition more human-readable
1 parent 8e17478 commit 7f515c3

File tree

1 file changed

+27
-20
lines changed

1 file changed

+27
-20
lines changed

src/sagemaker/estimator.py

Lines changed: 27 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -696,37 +696,44 @@ def _stage_user_code_in_s3(self) -> str:
696696
Returns: S3 URI
697697
"""
698698
if is_pipeline_variable(self.output_path):
699-
code_bucket = self.sagemaker_session.default_bucket()
700699
if self.code_location is None:
700+
code_bucket = self.sagemaker_session.default_bucket()
701701
code_s3_prefix = "{}/{}".format(self._current_job_name, "source")
702-
kms_key = self.output_kms_key
703-
else:
704-
code_bucket, key_prefix = parse_s3_url(self.code_location)
705-
code_s3_prefix = "/".join(
706-
filter(None, [key_prefix, self._current_job_name, "source"])
707-
)
708-
kms_key = (
709-
self.output_kms_key
710-
if code_bucket == self.sagemaker_session.default_bucket()
711-
else None
712-
)
713-
else:
714-
if self.code_location is None:
715-
code_bucket, _ = parse_s3_url(self.output_path)
716-
code_s3_prefix = "{}/{}".format(self._current_job_name, "source")
702+
kms_key = None
717703
else:
718704
code_bucket, key_prefix = parse_s3_url(self.code_location)
719705
code_s3_prefix = "/".join(
720706
filter(None, [key_prefix, self._current_job_name, "source"])
721707
)
722708

709+
output_bucket = self.sagemaker_session.default_bucket()
710+
kms_key = self.output_kms_key if code_bucket == output_bucket else None
711+
else:
723712
local_mode = self.output_path.startswith("file://")
724-
725713
if local_mode:
726-
kms_key = None
714+
if self.code_location is None:
715+
code_bucket = self.sagemaker_session.default_bucket()
716+
code_s3_prefix = "{}/{}".format(self._current_job_name, "source")
717+
kms_key = None
718+
else:
719+
code_bucket, key_prefix = parse_s3_url(self.code_location)
720+
code_s3_prefix = "/".join(
721+
filter(None, [key_prefix, self._current_job_name, "source"])
722+
)
723+
kms_key = None
727724
else:
728-
output_bucket, _ = parse_s3_url(self.output_path)
729-
kms_key = self.output_kms_key if code_bucket == output_bucket else None
725+
if self.code_location is None:
726+
code_bucket, _ = parse_s3_url(self.output_path)
727+
code_s3_prefix = "{}/{}".format(self._current_job_name, "source")
728+
kms_key = self.output_kms_key
729+
else:
730+
code_bucket, key_prefix = parse_s3_url(self.code_location)
731+
code_s3_prefix = "/".join(
732+
filter(None, [key_prefix, self._current_job_name, "source"])
733+
)
734+
735+
output_bucket, _ = parse_s3_url(self.output_path)
736+
kms_key = self.output_kms_key if code_bucket == output_bucket else None
730737

731738
return tar_and_upload_dir(
732739
session=self.sagemaker_session.boto_session,

0 commit comments

Comments
 (0)