Skip to content

Commit 8224f3a

Browse files
fix: sklearn integ tests, remove swallowing exception on feature group delete attempt (#2563)
* Remove swallowing exception on feature group delete attempt * fix black format issues and update test for sklearn * fix passing in python3 as command * fix passing in python3 as command for network config test * remove asserts that no longer hold Co-authored-by: Ahsan Khan <[email protected]>
1 parent 11577fe commit 8224f3a

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

tests/integ/test_feature_store.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,4 +312,4 @@ def cleanup_feature_group(feature_group: FeatureGroup):
312312
try:
313313
feature_group.delete()
314314
except Exception:
315-
pass
315+
raise RuntimeError(f"Failed to delete feature group with name {feature_group.name}")

tests/integ/test_processing.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ def test_sklearn_with_customizations(
162162
sklearn_processor = SKLearnProcessor(
163163
framework_version=sklearn_latest_version,
164164
role=ROLE,
165+
command=["python3"],
165166
instance_type=cpu_instance_type,
166167
instance_count=1,
167168
volume_size_in_gb=100,
@@ -287,7 +288,6 @@ def test_sklearn_with_custom_default_bucket(
287288

288289
assert job_description["ProcessingInputs"][0]["InputName"] == "dummy_input"
289290
assert custom_bucket_name in job_description["ProcessingInputs"][0]["S3Input"]["S3Uri"]
290-
291291
assert job_description["ProcessingJobName"].startswith("test-sklearn-with-customizations")
292292

293293
assert job_description["ProcessingJobStatus"] == "Completed"
@@ -677,6 +677,7 @@ def test_sklearn_with_network_config(sagemaker_session, sklearn_latest_version,
677677
sklearn_processor = SKLearnProcessor(
678678
framework_version=sklearn_latest_version,
679679
role=ROLE,
680+
command=["python3"],
680681
instance_type=cpu_instance_type,
681682
instance_count=1,
682683
sagemaker_session=sagemaker_session,

0 commit comments

Comments
 (0)