Skip to content

Commit 8366ef7

Browse files
committed
add more test
1 parent 6a51bfe commit 8366ef7

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

tests/unit/sagemaker/jumpstart/test_notebook_utils.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
list_jumpstart_models,
2626
list_jumpstart_scripts,
2727
list_jumpstart_tasks,
28+
_is_valid_version,
2829
)
2930

3031

@@ -185,6 +186,13 @@ def test_list_jumpstart_frameworks(
185186
patched_get_model_specs.assert_not_called()
186187

187188

189+
def test_is_valid_version():
190+
valid_version_strs = ["1.0", "1.0.0", "2012.4", "1!1.0", "1.dev0", "1.2.3+abc.dev1"]
191+
invalid_version_strs = ["1.1.053_m", "invalid version", "v1-1.0-v2"]
192+
assert all(_is_valid_version(v) for v in valid_version_strs)
193+
assert not any(_is_valid_version(v) for v in invalid_version_strs)
194+
195+
188196
class ListJumpStartModels(TestCase):
189197
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
190198
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")

0 commit comments

Comments
 (0)