fix: update git utils temp file (#2057)

Co-authored-by: Ahsan Z Khan <[email protected]>

Author: metrizable

src/sagemaker/git_utils.py

@@ -282,8 +282,7 @@ def _run_clone_command(repo_url, dest_dir):
             write_pipe = open(sshnoprompt.name, "w")
             write_pipe.write("ssh -oBatchMode=yes $@")
             write_pipe.close()
-            # 511 in decimal is same as 777 in octal
-            os.chmod(sshnoprompt.name, 511)
+            os.chmod(sshnoprompt.name, 0o511)
             my_env["GIT_SSH"] = sshnoprompt.name
             subprocess.check_call(["git", "clone", repo_url, dest_dir], env=my_env)
 

tests/unit/test_git_utils.py

@@ -15,7 +15,7 @@
 import pytest
 import os
 import subprocess
-from mock import patch
+from mock import patch, ANY
 
 from sagemaker import git_utils
 
@@ -180,7 +180,7 @@ def test_git_clone_repo_dependencies_not_exist(exists, isdir, isfile, mkdtemp, c
 @patch("subprocess.check_call")
 @patch("tempfile.mkdtemp", return_value=REPO_DIR)
 @patch("os.path.isfile", return_value=True)
-def test_git_clone_repo_with_username_password_no_2fa(sfile, mkdtemp, check_call):
+def test_git_clone_repo_with_username_password_no_2fa(isfile, mkdtemp, check_call):
     git_config = {
         "repo": PRIVATE_GIT_REPO,
         "branch": PRIVATE_BRANCH,
@@ -262,12 +262,14 @@ def test_git_clone_repo_with_token_2fa(isfile, mkdtemp, check_call):
 
 
 @patch("subprocess.check_call")
+@patch("os.chmod")
 @patch("tempfile.mkdtemp", return_value=REPO_DIR)
 @patch("os.path.isfile", return_value=True)
-def test_git_clone_repo_ssh(isfile, mkdtemp, check_call):
+def test_git_clone_repo_ssh(isfile, mkdtemp, chmod, check_call):
     git_config = {"repo": PRIVATE_GIT_REPO_SSH, "branch": PRIVATE_BRANCH, "commit": PRIVATE_COMMIT}
     entry_point = "entry_point"
     ret = git_utils.git_clone_repo(git_config, entry_point)
+    chmod.assert_any_call(ANY, 0o511)
     assert ret["entry_point"] == "/tmp/repo_dir/entry_point"
     assert ret["source_dir"] is None
     assert ret["dependencies"] is None