Skip to content

Commit 876a304

Browse files
committed
fix: update broken integ tests
And refactor some others to use SimpleBaseSerializer
1 parent 47ee585 commit 876a304

File tree

5 files changed

+13
-20
lines changed

5 files changed

+13
-20
lines changed

doc/frameworks/xgboost/using_xgboost.rst

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,7 @@ inference against your model.
192192

193193
.. code::
194194
195-
serializer = StringSerializer()
196-
serializer.CONTENT_TYPE = "text/libsvm"
195+
serializer = StringSerializer(content_type="text/libsvm")
197196
198197
predictor = estimator.deploy(
199198
initial_instance_count=1,

tests/integ/test_byo_estimator.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import sagemaker
2121
from sagemaker import image_uris
2222
from sagemaker.estimator import Estimator
23-
from sagemaker.serializers import BaseSerializer
23+
from sagemaker.serializers import SimpleBaseSerializer
2424
from sagemaker.utils import unique_name_from_base
2525
from tests.integ import DATA_DIR, TRAINING_DEFAULT_TIMEOUT_MINUTES, datasets
2626
from tests.integ.timeout import timeout, timeout_and_delete_endpoint_by_name
@@ -36,9 +36,8 @@ def training_set():
3636
return datasets.one_p_mnist()
3737

3838

39-
class _FactorizationMachineSerializer(BaseSerializer):
40-
41-
CONTENT_TYPE = "application/json"
39+
class _FactorizationMachineSerializer(SimpleBaseSerializer):
40+
# SimpleBaseSerializer already uses "application/json" CONTENT_TYPE by default
4241

4342
def serialize(self, data):
4443
js = {"instances": []}

tests/integ/test_neo_mxnet.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@ def test_attach_deploy(
7272
output_path=estimator.output_path,
7373
)
7474

75-
serializer = JSONSerializer()
76-
serializer.CONTENT_TYPE = "application/vnd+python.numpy+binary"
75+
serializer = JSONSerializer(content_type="application/vnd+python.numpy+binary")
7776

7877
predictor = estimator.deploy(
7978
1,
@@ -112,8 +111,7 @@ def test_deploy_model(
112111
sagemaker_session=sagemaker_session,
113112
)
114113

115-
serializer = JSONSerializer()
116-
serializer.CONTENT_TYPE = "application/vnd+python.numpy+binary"
114+
serializer = JSONSerializer(content_type="application/vnd+python.numpy+binary")
117115

118116
model.compile(
119117
target_instance_family=cpu_instance_family,
@@ -165,8 +163,7 @@ def test_inferentia_deploy_model(
165163
output_path="/".join(model_data.split("/")[:-1]),
166164
)
167165

168-
serializer = JSONSerializer()
169-
serializer.CONTENT_TYPE = "application/vnd+python.numpy+binary"
166+
serializer = JSONSerializer(content_type="application/vnd+python.numpy+binary")
170167

171168
predictor = model.deploy(
172169
1, inf_instance_type, serializer=serializer, endpoint_name=endpoint_name

tests/integ/test_tuner.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
from sagemaker.estimator import Estimator
2929
from sagemaker.mxnet.estimator import MXNet
3030
from sagemaker.pytorch import PyTorch
31-
from sagemaker.serializers import BaseSerializer
31+
from sagemaker.serializers import SimpleBaseSerializer
3232
from sagemaker.tensorflow import TensorFlow
3333
from sagemaker.tuner import (
3434
IntegerParameter,
@@ -884,9 +884,8 @@ def test_tuning_byo_estimator(sagemaker_session, cpu_instance_type):
884884

885885

886886
# Serializer for the Factorization Machines predictor (for BYO example)
887-
class _FactorizationMachineSerializer(BaseSerializer):
888-
889-
CONTENT_TYPE = "application/json"
887+
class _FactorizationMachineSerializer(SimpleBaseSerializer):
888+
# SimpleBaseSerializer already uses "application/json" CONTENT_TYPE by default
890889

891890
def serialize(self, data):
892891
js = {"instances": []}

tests/integ/test_tuner_multi_algo.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from sagemaker.analytics import HyperparameterTuningJobAnalytics
2222
from sagemaker.deserializers import JSONDeserializer
2323
from sagemaker.estimator import Estimator
24-
from sagemaker.serializers import BaseSerializer
24+
from sagemaker.serializers import SimpleBaseSerializer
2525
from sagemaker.tuner import ContinuousParameter, IntegerParameter, HyperparameterTuner
2626
from tests.integ import datasets, DATA_DIR, TUNING_DEFAULT_TIMEOUT_MINUTES
2727
from tests.integ.timeout import timeout, timeout_and_delete_endpoint_by_name
@@ -219,9 +219,8 @@ def _create_training_inputs(sagemaker_session):
219219
return {"train": s3_train_data, "test": s3_train_data}
220220

221221

222-
class PredictionDataSerializer(BaseSerializer):
223-
224-
CONTENT_TYPE = "application/json"
222+
class PredictionDataSerializer(SimpleBaseSerializer):
223+
# SimpleBaseSerializer already uses "application/json" CONTENT_TYPE by default
225224

226225
def serialize(self, data):
227226
js = {"instances": []}

0 commit comments

Comments
 (0)