Skip to content

Commit 879b70c

Browse files
committed
Corrections
1 parent 31f0215 commit 879b70c

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

src/sagemaker/image_uri_config/pytorch.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -890,7 +890,7 @@
890890
"us-west-1": "763104351884",
891891
"us-west-2": "763104351884"
892892
},
893-
"repository": "pytorch-inference"
893+
"repository": "pytorch-training"
894894
}
895895
}
896896
}

tests/conftest.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,8 @@ def pytorch_training_py_version(pytorch_training_version, request):
186186
return request.param
187187
elif Version(pytorch_training_version) == Version("1.7.1"):
188188
return "py36"
189+
elif Version(pytorch_training_version) >= Version("1.9"):
190+
return "py38"
189191
else:
190192
return "py3"
191193

@@ -196,6 +198,8 @@ def pytorch_inference_py_version(pytorch_inference_version, request):
196198
return request.param
197199
elif Version(pytorch_inference_version) == Version("1.7.1"):
198200
return "py36"
201+
elif Version(pytorch_inference_version) >= Version("1.9"):
202+
return "py38"
199203
else:
200204
return "py3"
201205

tests/unit/test_processing.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,14 +284,20 @@ def test_sklearn_with_all_parameters_via_run_args_called_twice(
284284
@patch("os.path.exists", return_value=True)
285285
@patch("os.path.isfile", return_value=True)
286286
def test_pytorch_processor_with_required_parameters(
287-
exists_mock, isfile_mock, botocore_resolver, sagemaker_session, pytorch_training_version
287+
exists_mock,
288+
isfile_mock,
289+
botocore_resolver,
290+
sagemaker_session,
291+
pytorch_training_version,
292+
pytorch_training_py_version,
288293
):
289294
botocore_resolver.return_value.construct_endpoint.return_value = {"hostname": ECR_HOSTNAME}
290295

291296
processor = PyTorchProcessor(
292297
role=ROLE,
293298
instance_type="ml.m4.xlarge",
294299
framework_version=pytorch_training_version,
300+
py_version=pytorch_training_py_version,
295301
instance_count=1,
296302
sagemaker_session=sagemaker_session,
297303
)

0 commit comments

Comments
 (0)