fix: Add more unit tests

Author: Dewen Qi

src/sagemaker/workflow/entities.py

@@ -116,3 +116,21 @@ def startswith(
             bool: Always return False as Pipeline variables are parsed during execution runtime
         """
         return False
+
+    def endswith(
+        self,
+        suffix: Union[str, tuple],  # pylint: disable=unused-argument
+        start: Optional[int] = None,  # pylint: disable=unused-argument
+        end: Optional[int] = None,  # pylint: disable=unused-argument
+    ) -> bool:
+        """Simulate the Python string's built-in method: endswith
+
+        Args:
+            suffix (str, tuple): The (tuple of) string to be checked.
+            start (int): To set the start index of the matching boundary (default: None).
+            end (int): To set the end index of the matching boundary (default: None).
+
+        Return:
+            bool: Always return False as Pipeline variables are parsed during execution runtime
+        """
+        return False

tests/integ/sagemaker/workflow/test_tuning_steps.py

@@ -105,7 +105,7 @@ def test_tuning_single_algo(
         max_retry_attempts=3,
     )
 
-    min_batch_size = ParameterString(name="MinBatchSize", default_value="64")
+    min_batch_size = ParameterInteger(name="MinBatchSize", default_value=64)
     max_batch_size = ParameterInteger(name="MaxBatchSize", default_value=128)
     hyperparameter_ranges = {
         "batch-size": IntegerParameter(min_batch_size, max_batch_size),

tests/unit/sagemaker/workflow/test_execution_variables.py

@@ -27,16 +27,28 @@ def test_to_string():
 
     assert var.to_string() == var
 
+
+def test_implicit_value():
+    var = ExecutionVariables.START_DATETIME
+
     with pytest.raises(TypeError) as error:
         str(var)
-
     assert str(error.value) == "Pipeline variables do not support __str__ operation."
 
+    with pytest.raises(TypeError) as error:
+        int(var)
+    assert str(error.value) == "Pipeline variables do not support __int__ operation."
+
+    with pytest.raises(TypeError) as error:
+        float(var)
+    assert str(error.value) == "Pipeline variables do not support __float__ operation."
+
 
-def test_startswith():
+def test_string_builtin_funcs_that_return_bool():
     prop = ExecutionVariables.PIPELINE_NAME
     # The execution var will only be parsed in runtime (Pipeline backend) so not able to tell in SDK
     assert not prop.startswith("MyPipeline")
+    assert not prop.endswith("MyPipeline")
 
 
 def test_add_func():

tests/unit/sagemaker/workflow/test_functions.py

@@ -75,16 +75,28 @@ def test_to_string_on_join():
 
     assert func.to_string() == func
 
+
+def test_implicit_value_on_join():
+    func = Join(values=[1, "a", False, 1.1])
+
     with pytest.raises(TypeError) as error:
         str(func)
-
     assert str(error.value) == "Pipeline variables do not support __str__ operation."
 
+    with pytest.raises(TypeError) as error:
+        int(func)
+    assert str(error.value) == "Pipeline variables do not support __int__ operation."
+
+    with pytest.raises(TypeError) as error:
+        float(func)
+    assert str(error.value) == "Pipeline variables do not support __float__ operation."
+
 
-def test_startswith_on_join():
+def test_string_builtin_funcs_that_return_bool_on_join():
     func = Join(on=",", values=["s3:/", "my-bucket", "a"])
     # The func will only be parsed in runtime (Pipeline backend) so not able to tell in SDK
     assert not func.startswith("s3")
+    assert not func.endswith("s3")
 
 
 def test_add_func_of_join():
@@ -167,20 +179,36 @@ def test_to_string_on_json_get():
         },
     }
 
+
+def test_implicit_value_on_json_get():
+    func = JsonGet(
+        step_name="my-step",
+        property_file="my-property-file",
+        json_path="my-json-path",
+    )
+
     with pytest.raises(TypeError) as error:
         str(func)
-
     assert str(error.value) == "Pipeline variables do not support __str__ operation."
 
+    with pytest.raises(TypeError) as error:
+        int(func)
+    assert str(error.value) == "Pipeline variables do not support __int__ operation."
+
+    with pytest.raises(TypeError) as error:
+        float(func)
+    assert str(error.value) == "Pipeline variables do not support __float__ operation."
+
 
-def test_startswith_on_json_get():
+def test_string_builtin_funcs_that_return_bool_on_json_get():
     func = JsonGet(
         step_name="my-step",
         property_file="my-property-file",
         json_path="my-json-path",
     )
     # The func will only be parsed in runtime (Pipeline backend) so not able to tell in SDK
     assert not func.startswith("s3")
+    assert not func.endswith("s3")
 
 
 def test_add_func_of_json_get():

tests/unit/sagemaker/workflow/test_parameters.py

@@ -102,17 +102,31 @@ def test_parsable_parameter_string():
     assert urlparse(param).scheme == "s3"
 
 
-def test_startswith_on_parameter_string():
+def test_string_builtin_funcs_that_return_bool_on_parameter_string():
     param = ParameterString("MyString", default_value="s3://foo/bar/baz.csv")
     # The param will only be parsed in runtime (Pipeline backend) so not able to tell in SDK
     assert not param.startswith("s3")
+    assert not param.endswith("s3")
 
 
 def test_add_func():
     param_str = ParameterString(name="MyString", default_value="s3://foo/bar/baz.csv")
     param_int = ParameterInteger(name="MyInteger", default_value=3)
+    param_float = ParameterFloat(name="MyFloat", default_value=1.5)
+    param_bool = ParameterBoolean(name="MyBool")
 
     with pytest.raises(TypeError) as error:
         param_str + param_int
+    assert str(error.value) == "Pipeline variables do not support concatenation."
+
+    with pytest.raises(TypeError) as error:
+        param_int + param_float
+    assert str(error.value) == "Pipeline variables do not support concatenation."
 
+    with pytest.raises(TypeError) as error:
+        param_float + param_bool
+    assert str(error.value) == "Pipeline variables do not support concatenation."
+
+    with pytest.raises(TypeError) as error:
+        param_bool + param_str
     assert str(error.value) == "Pipeline variables do not support concatenation."

tests/unit/sagemaker/workflow/test_properties.py

@@ -105,16 +105,28 @@ def test_to_string():
         },
     }
 
+
+def test_implicit_value():
+    prop = Properties("Steps.MyStep", "DescribeTrainingJobResponse")
+
     with pytest.raises(TypeError) as error:
         str(prop.CreationTime)
-
     assert str(error.value) == "Pipeline variables do not support __str__ operation."
 
+    with pytest.raises(TypeError) as error:
+        int(prop.CreationTime)
+    assert str(error.value) == "Pipeline variables do not support __int__ operation."
+
+    with pytest.raises(TypeError) as error:
+        float(prop.CreationTime)
+    assert str(error.value) == "Pipeline variables do not support __float__ operation."
+
 
-def test_startswith():
+def test_string_builtin_funcs_that_return_bool():
     prop = Properties("Steps.MyStep", "DescribeModelPackageOutput")
     # The prop will only be parsed in runtime (Pipeline backend) so not able to tell in SDK
     assert not prop.startswith("s3")
+    assert not prop.endswith("s3")
 
 
 def test_add_func():