Skip to content

Commit 8b83b46

Browse files
committed
change: add missing comma next to 'Domain' property to fix failing pylint, flake8 issue
1 parent 4ea8a27 commit 8b83b46

File tree

9 files changed

+19
-19
lines changed

9 files changed

+19
-19
lines changed

src/sagemaker/estimator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1345,7 +1345,7 @@ def register(
13451345
description,
13461346
drift_check_baselines=drift_check_baselines,
13471347
customer_metadata_properties=customer_metadata_properties,
1348-
domain=domain
1348+
domain=domain,
13491349
)
13501350

13511351
@property

src/sagemaker/model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ def register(
309309
drift_check_baselines=None,
310310
customer_metadata_properties=None,
311311
validation_specification=None,
312-
domain=None
312+
domain=None,
313313
):
314314
"""Creates a model package for creating SageMaker models or listing on Marketplace.
315315
@@ -368,7 +368,7 @@ def register(
368368
drift_check_baselines=drift_check_baselines,
369369
customer_metadata_properties=customer_metadata_properties,
370370
validation_specification=validation_specification,
371-
domain=domain
371+
domain=domain,
372372
)
373373
model_package = self.sagemaker_session.create_model_package_from_containers(
374374
**model_pkg_args

src/sagemaker/mxnet/model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ def register(
158158
description=None,
159159
drift_check_baselines=None,
160160
customer_metadata_properties=None,
161-
domain=None
161+
domain=None,
162162
):
163163
"""Creates a model package for creating SageMaker models or listing on Marketplace.
164164
@@ -217,7 +217,7 @@ def register(
217217
description,
218218
drift_check_baselines=drift_check_baselines,
219219
customer_metadata_properties=customer_metadata_properties,
220-
domain=domain
220+
domain=domain,
221221
)
222222

223223
def prepare_container_def(

src/sagemaker/pytorch/model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ def register(
159159
description=None,
160160
drift_check_baselines=None,
161161
customer_metadata_properties=None,
162-
domain=None
162+
domain=None,
163163
):
164164
"""Creates a model package for creating SageMaker models or listing on Marketplace.
165165
@@ -218,7 +218,7 @@ def register(
218218
description,
219219
drift_check_baselines=drift_check_baselines,
220220
customer_metadata_properties=customer_metadata_properties,
221-
domain=domain
221+
domain=domain,
222222
)
223223

224224
def prepare_container_def(

src/sagemaker/session.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2803,7 +2803,7 @@ def create_model_package_from_containers(
28032803
drift_check_baselines=None,
28042804
customer_metadata_properties=None,
28052805
validation_specification=None,
2806-
domain=None
2806+
domain=None,
28072807
):
28082808
"""Get request dictionary for CreateModelPackage API.
28092809
@@ -2851,7 +2851,7 @@ def create_model_package_from_containers(
28512851
drift_check_baselines=drift_check_baselines,
28522852
customer_metadata_properties=customer_metadata_properties,
28532853
validation_specification=validation_specification,
2854-
domain=domain
2854+
domain=domain,
28552855
)
28562856

28572857
def submit(request):
@@ -4222,7 +4222,7 @@ def get_model_package_args(
42224222
drift_check_baselines=None,
42234223
customer_metadata_properties=None,
42244224
validation_specification=None,
4225-
domain=None
4225+
domain=None,
42264226
):
42274227
"""Get arguments for create_model_package method.
42284228
@@ -4253,8 +4253,8 @@ def get_model_package_args(
42534253
drift_check_baselines (DriftCheckBaselines): DriftCheckBaselines object (default: None).
42544254
customer_metadata_properties (dict[str, str]): A dictionary of key-value paired
42554255
metadata properties (default: None).
4256-
domain (str): Domain values can be "COMPUTER_VISION, NATURAL_LANGUAGE_PROCESSING,
4257-
MACHINE_LEARNING" (default: None).
4256+
domain (str): Domain values can be "COMPUTER_VISION", "NATURAL_LANGUAGE_PROCESSING",
4257+
"MACHINE_LEARNING" (default: None).
42584258
Returns:
42594259
dict: A dictionary of method argument names and values.
42604260
"""
@@ -4318,7 +4318,7 @@ def get_create_model_package_request(
43184318
drift_check_baselines=None,
43194319
customer_metadata_properties=None,
43204320
validation_specification=None,
4321-
domain=None
4321+
domain=None,
43224322
):
43234323
"""Get request dictionary for CreateModelPackage API.
43244324

src/sagemaker/tensorflow/model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ def register(
205205
description=None,
206206
drift_check_baselines=None,
207207
customer_metadata_properties=None,
208-
domain=None
208+
domain=None,
209209
):
210210
"""Creates a model package for creating SageMaker models or listing on Marketplace.
211211
@@ -264,7 +264,7 @@ def register(
264264
description,
265265
drift_check_baselines=drift_check_baselines,
266266
customer_metadata_properties=customer_metadata_properties,
267-
domain=domain
267+
domain=domain,
268268
)
269269

270270
def deploy(

src/sagemaker/workflow/_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ def arguments(self) -> RequestType:
432432
tags=self.tags,
433433
container_def_list=self.container_def_list,
434434
customer_metadata_properties=self.customer_metadata_properties,
435-
domain=self.domain
435+
domain=self.domain,
436436
)
437437

438438
request_dict = get_create_model_package_request(**model_package_args)

tests/integ/sagemaker/workflow/test_model_create_and_registration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,7 @@ def test_model_registration_with_drift_check_baselines(
573573
model_metrics=model_metrics,
574574
drift_check_baselines=drift_check_baselines,
575575
customer_metadata_properties=customer_metadata_properties,
576-
domain=domain
576+
domain=domain,
577577
)
578578

579579
pipeline = Pipeline(

tests/unit/test_session.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2401,7 +2401,7 @@ def test_create_model_package_from_containers_all_args(sagemaker_session):
24012401
description=description,
24022402
drift_check_baselines=drift_check_baselines,
24032403
customer_metadata_properties=customer_metadata_properties,
2404-
domain=domain
2404+
domain=domain,
24052405
)
24062406
expected_args = {
24072407
"ModelPackageName": model_package_name,
@@ -2419,7 +2419,7 @@ def test_create_model_package_from_containers_all_args(sagemaker_session):
24192419
"ModelApprovalStatus": approval_status,
24202420
"DriftCheckBaselines": drift_check_baselines,
24212421
"CustomerMetadataProperties": customer_metadata_properties,
2422-
"Domain": domain
2422+
"Domain": domain,
24232423
}
24242424
sagemaker_session.sagemaker_client.create_model_package.assert_called_with(**expected_args)
24252425

0 commit comments

Comments
 (0)