Skip to content

Commit 92db04a

Browse files
committed
Remove unnecessary test runs
1 parent 8cb7cd8 commit 92db04a

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

tests/integ/test_chainer_train.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import pytest
1919
import numpy
2020

21+
from sagemaker.chainer.defaults import CHAINER_VERSION
2122
from sagemaker.chainer.estimator import Chainer
2223
from sagemaker.chainer.model import ChainerModel
2324
from sagemaker.utils import sagemaker_timestamp
@@ -70,25 +71,23 @@ def test_attach_deploy(chainer_training_job, sagemaker_session):
7071
_predict_and_assert(predictor)
7172

7273

73-
def test_deploy_model(chainer_training_job, sagemaker_session, chainer_full_version):
74+
def test_deploy_model(chainer_training_job, sagemaker_session):
7475
endpoint_name = 'test-chainer-deploy-model-{}'.format(sagemaker_timestamp())
7576
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session, minutes=20):
7677
desc = sagemaker_session.sagemaker_client.describe_training_job(TrainingJobName=chainer_training_job)
7778
model_data = desc['ModelArtifacts']['S3ModelArtifacts']
7879
script_path = os.path.join(DATA_DIR, 'chainer_mnist', 'mnist.py')
79-
model = ChainerModel(model_data, 'SageMakerRole', entry_point=script_path,
80-
framework_version=chainer_full_version,
81-
sagemaker_session=sagemaker_session)
80+
model = ChainerModel(model_data, 'SageMakerRole', entry_point=script_path, sagemaker_session=sagemaker_session)
8281
predictor = model.deploy(1, "ml.m4.xlarge", endpoint_name=endpoint_name)
8382
_predict_and_assert(predictor)
8483

8584

86-
def test_async_fit(sagemaker_session, chainer_full_version):
85+
def test_async_fit(sagemaker_session):
8786
endpoint_name = 'test-chainer-attach-deploy-{}'.format(sagemaker_timestamp())
8887

8988
with timeout(minutes=5):
9089
training_job_name = _run_mnist_training_job(sagemaker_session, "ml.c4.xlarge", 1,
91-
chainer_full_version, wait=False)
90+
chainer_full_version=CHAINER_VERSION, wait=False)
9291

9392
print("Waiting to re-attach to the training job: %s" % training_job_name)
9493
time.sleep(20)

0 commit comments

Comments
 (0)