Skip to content

Commit 985da79

Browse files
committed
fix: fix missing 'domain' property for framework models
1 parent e2b54ee commit 985da79

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/sagemaker/huggingface/model.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,7 @@ def register(
304304
approval_status=None,
305305
description=None,
306306
drift_check_baselines=None,
307+
domain=None,
307308
):
308309
"""Creates a model package for creating SageMaker models or listing on Marketplace.
309310
@@ -331,6 +332,8 @@ def register(
331332
or "PendingManualApproval". Defaults to ``PendingManualApproval``.
332333
description (str): Model Package description. Defaults to ``None``.
333334
drift_check_baselines (DriftCheckBaselines): DriftCheckBaselines object (default: None).
335+
domain (str): Domain values can be "COMPUTER_VISION", "NATURAL_LANGUAGE_PROCESSING",
336+
"MACHINE_LEARNING" (default: None).
334337
335338
Returns:
336339
A `sagemaker.model.ModelPackage` instance.
@@ -359,6 +362,7 @@ def register(
359362
approval_status,
360363
description,
361364
drift_check_baselines=drift_check_baselines,
365+
domain=domain,
362366
)
363367

364368
def prepare_container_def(

src/sagemaker/sklearn/model.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ def register(
151151
marketplace_cert=False,
152152
approval_status=None,
153153
description=None,
154+
domain=None,
154155
):
155156
"""Creates a model package for creating SageMaker models or listing on Marketplace.
156157
@@ -175,6 +176,8 @@ def register(
175176
approval_status (str): Model Approval Status, values can be "Approved", "Rejected",
176177
or "PendingManualApproval" (default: "PendingManualApproval").
177178
description (str): Model Package description (default: None).
179+
domain (str): Domain values can be "COMPUTER_VISION", "NATURAL_LANGUAGE_PROCESSING",
180+
"MACHINE_LEARNING" (default: None).
178181
179182
Returns:
180183
A `sagemaker.model.ModelPackage` instance.
@@ -202,6 +205,7 @@ def register(
202205
marketplace_cert,
203206
approval_status,
204207
description,
208+
domain=domain,
205209
)
206210

207211
def prepare_container_def(

0 commit comments

Comments
 (0)