Skip to content

Commit a0b9ae8

Browse files
committed
update error message
1 parent 5b3003e commit a0b9ae8

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

src/sagemaker/tensorflow/estimator.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,6 @@ def _validate_args(self, py_version, framework_version):
161161
raise AttributeError(msg)
162162

163163
if self._only_legacy_mode_supported() and self.image_name is None:
164-
additional_instructions = ""
165-
if self.model_dir is not False:
166-
additional_instructions = " and set 'model_dir=False'"
167-
168164
legacy_image_uri = fw.create_image_uri(
169165
self.sagemaker_session.boto_region_name,
170166
"tensorflow",
@@ -176,10 +172,10 @@ def _validate_args(self, py_version, framework_version):
176172
# TODO: add link to docs to explain how to use legacy mode with v2
177173
msg = (
178174
"TF {} supports only legacy mode. Please supply the image URI directly with "
179-
"'image_name={}'{}. If you were using any legacy mode parameters "
175+
"'image_name={}' and set 'model_dir=False'. If you are using any legacy parameters "
180176
"(training_steps, evaluation_steps, checkpoint_path, requirements_file), "
181177
"make sure to pass them directly as hyperparameters instead."
182-
).format(self.framework_version, legacy_image_uri, additional_instructions)
178+
).format(self.framework_version, legacy_image_uri)
183179

184180
raise ValueError(msg)
185181

tests/unit/sagemaker/tensorflow/test_estimator_init.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def test_require_image_name_if_fw_ver_is_less_than_1_11(sagemaker_session, tf_ve
118118
"TF {version} supports only legacy mode. Please supply the image URI directly with "
119119
"'image_name=520713654638.dkr.ecr.{region}.amazonaws.com/"
120120
"sagemaker-tensorflow:{version}-cpu-py2' and set 'model_dir=False'. "
121-
"If you were using any legacy mode parameters (training_steps, evaluation_steps, "
121+
"If you are using any legacy parameters (training_steps, evaluation_steps, "
122122
"checkpoint_path, requirements_file), make sure to pass them directly as hyperparameters instead."
123123
).format(version=tf_version, region=REGION)
124124

0 commit comments

Comments
 (0)