Skip to content

Commit a24c216

Browse files
Merge pull request #1 from Christian-kam/my-fix-branch-master
fix: use the provided kms key to upload code
2 parents e8d16f8 + a9b43ef commit a24c216

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/sagemaker/processing.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,14 @@ def _normalize_args(
205205
"""
206206
self._current_job_name = self._generate_current_job_name(job_name=job_name)
207207

208-
inputs_with_code = self._include_code_in_inputs(inputs, code)
208+
inputs_with_code = self._include_code_in_inputs(inputs, code, kms_key)
209209
normalized_inputs = self._normalize_inputs(inputs_with_code, kms_key)
210210
normalized_outputs = self._normalize_outputs(outputs)
211211
self.arguments = arguments
212212

213213
return normalized_inputs, normalized_outputs
214214

215-
def _include_code_in_inputs(self, inputs, _code):
215+
def _include_code_in_inputs(self, inputs, _code, kms_key=None):
216216
"""A no op in the base class to include code in the processing job inputs.
217217
218218
Args:
@@ -475,7 +475,7 @@ def run(
475475
if wait:
476476
self.latest_job.wait(logs=logs)
477477

478-
def _include_code_in_inputs(self, inputs, code):
478+
def _include_code_in_inputs(self, inputs, code, kms_key=None):
479479
"""Converts code to appropriate input and includes in input list.
480480
481481
Side effects include:
@@ -493,7 +493,7 @@ def _include_code_in_inputs(self, inputs, code):
493493
list[:class:`~sagemaker.processing.ProcessingInput`]: inputs together with the
494494
code as `ProcessingInput`.
495495
"""
496-
user_code_s3_uri = self._handle_user_code_url(code)
496+
user_code_s3_uri = self._handle_user_code_url(code,kms_key)
497497
user_script_name = self._get_user_code_name(code)
498498

499499
inputs_with_code = self._convert_code_and_add_to_inputs(inputs, user_code_s3_uri)
@@ -515,7 +515,7 @@ def _get_user_code_name(self, code):
515515
code_url = urlparse(code)
516516
return os.path.basename(code_url.path)
517517

518-
def _handle_user_code_url(self, code):
518+
def _handle_user_code_url(self, code, kms_key=None):
519519
"""Gets the S3 URL containing the user's code.
520520
521521
Inspects the scheme the customer passed in ("s3://" for code in S3, "file://" or nothing
@@ -551,7 +551,7 @@ def _handle_user_code_url(self, code):
551551
code
552552
)
553553
)
554-
user_code_s3_uri = self._upload_code(code_path)
554+
user_code_s3_uri = self._upload_code(code_path,kms_key)
555555
else:
556556
raise ValueError(
557557
"code {} url scheme {} is not recognized. Please pass a file path or S3 url".format(
@@ -560,7 +560,7 @@ def _handle_user_code_url(self, code):
560560
)
561561
return user_code_s3_uri
562562

563-
def _upload_code(self, code):
563+
def _upload_code(self, code, kms_key=None):
564564
"""Uploads a code file or directory specified as a string
565565
and returns the S3 URI.
566566
@@ -579,7 +579,7 @@ def _upload_code(self, code):
579579
self._CODE_CONTAINER_INPUT_NAME,
580580
)
581581
return s3.S3Uploader.upload(
582-
local_path=code, desired_s3_uri=desired_s3_uri, sagemaker_session=self.sagemaker_session
582+
local_path=code, desired_s3_uri=desired_s3_uri, sagemaker_session=self.sagemaker_session, kms_key=kms_key
583583
)
584584

585585
def _convert_code_and_add_to_inputs(self, inputs, s3_uri):

0 commit comments

Comments
 (0)