Skip to content

Commit a2a95e2

Browse files
refactor changes
1 parent 084d95a commit a2a95e2

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/sagemaker/session.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,7 @@ def __init__(
233233
self._default_bucket_name_override = default_bucket
234234
# this may also be set again inside :func:`_initialize` if it is None
235235
self.default_bucket_prefix = default_bucket_prefix
236+
self._default_bucket_set_by_sdk = False
236237

237238
self.s3_resource = None
238239
self.s3_client = None
@@ -542,24 +543,22 @@ def default_bucket(self):
542543

543544
region = self.boto_session.region_name
544545

545-
_default_bucket_set_by_sdk = False
546546
default_bucket = self._default_bucket_name_override
547547
if not default_bucket:
548548
default_bucket = generate_default_sagemaker_bucket_name(self.boto_session)
549-
_default_bucket_set_by_sdk = True
549+
self._default_bucket_set_by_sdk = True
550550

551551
self._create_s3_bucket_if_it_does_not_exist(
552552
bucket_name=default_bucket,
553553
region=region,
554-
default_bucket_set_by_sdk=_default_bucket_set_by_sdk,
555554
)
556555

557556
self._default_bucket = default_bucket
558557

559558
return self._default_bucket
560559

561560
def _create_s3_bucket_if_it_does_not_exist(
562-
self, bucket_name, region, default_bucket_set_by_sdk
561+
self, bucket_name, region
563562
):
564563
"""Creates an S3 Bucket if it does not exist.
565564
@@ -628,7 +627,7 @@ def _create_s3_bucket_if_it_does_not_exist(
628627
else:
629628
raise
630629

631-
if default_bucket_set_by_sdk:
630+
if self._default_bucket_set_by_sdk:
632631
# make sure the s3 bucket is configured in users account.
633632
expected_bucket_owner_id = self.account_id()
634633
try:
@@ -641,7 +640,8 @@ def _create_s3_bucket_if_it_does_not_exist(
641640
if error_code == "403" and message == "Forbidden":
642641
LOGGER.error(
643642
"Since default_bucket param was not set, SageMaker Python SDK tried to use "
644-
"%s bucket. This bucket cannot be configured to use as it is not owned by Account %s. "
643+
"%s bucket. "
644+
"This bucket cannot be configured to use as it is not owned by Account %s. "
645645
"To unblock it's recommended to use custom default_bucket "
646646
"parameter in sagemaker.Session",
647647
bucket_name,

0 commit comments

Comments
 (0)