Skip to content

Commit aca3958

Browse files
committed
Address pr comments
1 parent 358a811 commit aca3958

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

CHANGELOG.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ CHANGELOG
1313
* build: added pylint
1414
* build: upgrade docker-compose to 1.23
1515
* enhancement: Frameworks: update warning for not setting framework_version as we aren't planning a breaking change anymore
16-
* feature: Estimator: add script mode and py3 support for TensorFlow
16+
* feature: Estimator: add script mode and Python 3 support for TensorFlow
1717

1818
1.14.1
1919
======

src/sagemaker/fw_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
'If you would like to use version {latest}, ' \
3232
'please add framework_version={latest} to your constructor.'
3333

34-
EMPTY_FRAMEWORK_VERSION_ERROR = 'framework_version is required for this estimator. ' \
34+
EMPTY_FRAMEWORK_VERSION_ERROR = 'framework_version is required for script mode estimator. ' \
3535
'Please add framework_version={} to your constructor to avoid this error.'
3636

3737
VALID_PY_VERSIONS = ['py2', 'py3']

src/sagemaker/tensorflow/estimator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ def _prepare_init_params_from_job_description(cls, job_details, model_channel_na
318318
model_channel_name)
319319

320320
# Move some of the tensorflow specific init params from hyperparameters into the main init params.
321-
for argument in ['checkpoint_path', 'training_steps', 'evaluation_steps', 'model_dir']:
321+
for argument in ('checkpoint_path', 'training_steps', 'evaluation_steps', 'model_dir'):
322322
value = init_params['hyperparameters'].pop(argument, None)
323323
if value is not None:
324324
init_params[argument] = value

0 commit comments

Comments
 (0)