Skip to content

Commit ad9016a

Browse files
committed
Revert "feat: private util for model eula key"
This reverts commit e2daefc.
1 parent 430a517 commit ad9016a

File tree

2 files changed

+0
-61
lines changed

2 files changed

+0
-61
lines changed

src/sagemaker/jumpstart/notebook_utils.py

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -475,30 +475,3 @@ def get_model_url(
475475
scope=JumpStartScriptScope.INFERENCE,
476476
)
477477
return model_specs.url
478-
479-
480-
def _get_model_eula_key(
481-
model_id: str,
482-
model_version: str,
483-
region: str = JUMPSTART_DEFAULT_REGION_NAME,
484-
sagemaker_session: Session = DEFAULT_JUMPSTART_SAGEMAKER_SESSION,
485-
) -> str:
486-
"""Retrieve S3 key for EULA text for gated models, or None for non-gated models.
487-
488-
Args:
489-
model_id (str): The model ID for which to retrieve the EULA S3 key.
490-
model_version (str): The model version for which to retrieve the EULA S3 key.
491-
region (str): Optional. The region from which to retrieve metadata.
492-
(Default: JUMPSTART_DEFAULT_REGION_NAME)
493-
sagemaker_session (sagemaker.session.Session): Optional. The SageMaker Session to use
494-
to retrieve the EULA S3 key.
495-
"""
496-
497-
model_specs = verify_model_region_and_return_specs(
498-
region=region,
499-
model_id=model_id,
500-
version=model_version,
501-
sagemaker_session=sagemaker_session,
502-
scope=JumpStartScriptScope.INFERENCE,
503-
)
504-
return model_specs.hosting_eula_key

tests/unit/sagemaker/jumpstart/test_notebook_utils.py

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,9 @@
1515
get_header_from_base_header,
1616
get_prototype_manifest,
1717
get_prototype_model_spec,
18-
get_special_model_spec,
1918
)
2019
from sagemaker.jumpstart.notebook_utils import (
2120
_generate_jumpstart_model_versions,
22-
_get_model_eula_key,
2321
get_model_url,
2422
list_jumpstart_frameworks,
2523
list_jumpstart_models,
@@ -700,35 +698,3 @@ def test_get_model_url(
700698
region=region,
701699
s3_client=DEFAULT_JUMPSTART_SAGEMAKER_SESSION.s3_client,
702700
)
703-
704-
705-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
706-
def test__get_model_eula_key(
707-
patched_get_model_specs: Mock,
708-
):
709-
710-
patched_get_model_specs.side_effect = get_special_model_spec
711-
712-
model_id, version = "gated_llama_neuron_model", "*"
713-
assert "fmhMetadata/eula/llamaEula.txt" == _get_model_eula_key(model_id, version)
714-
715-
model_id, version = "variant-model", "1.0.0"
716-
assert None is _get_model_eula_key(model_id, version)
717-
718-
region = "fake-region"
719-
720-
patched_get_model_specs.reset_mock()
721-
patched_get_model_specs.side_effect = lambda *largs, **kwargs: get_special_model_spec(
722-
*largs,
723-
region="us-west-2",
724-
**{key: value for key, value in kwargs.items() if key != "region"},
725-
)
726-
727-
_get_model_eula_key(model_id, version, region=region)
728-
729-
patched_get_model_specs.assert_called_once_with(
730-
model_id=model_id,
731-
version=version,
732-
region=region,
733-
s3_client=DEFAULT_JUMPSTART_SAGEMAKER_SESSION.s3_client,
734-
)

0 commit comments

Comments
 (0)