Skip to content

Commit b5fd242

Browse files
Fixing the order of populating container list (#2585)
Co-authored-by: Ahsan Khan <[email protected]>
1 parent 0fb0822 commit b5fd242

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/sagemaker/model.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1097,6 +1097,8 @@ def _upload_code(self, key_prefix, repack=False):
10971097

10981098
def _framework_env_vars(self):
10991099
"""Placeholder docstring"""
1100+
script_name = None
1101+
dir_name = None
11001102
if self.uploaded_code:
11011103
script_name = self.uploaded_code.script_name
11021104
if self.enable_network_isolation():
@@ -1105,10 +1107,8 @@ def _framework_env_vars(self):
11051107
dir_name = self.uploaded_code.s3_prefix
11061108
elif self.entry_point is not None:
11071109
script_name = self.entry_point
1108-
dir_name = "file://" + self.source_dir
1109-
else:
1110-
script_name = None
1111-
dir_name = None
1110+
if self.source_dir is not None:
1111+
dir_name = "file://" + self.source_dir
11121112

11131113
return {
11141114
SCRIPT_PARAM_NAME.upper(): script_name or str(),

tests/scripts/run-notebook-test.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,5 @@ echo "set SAGEMAKER_ROLE_ARN=$SAGEMAKER_ROLE_ARN"
3030
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_moving_from_framework_mode_to_script_mode/tensorflow_moving_from_framework_mode_to_script_mode.ipynb \
3131
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_script_mode_pipe_mode/tensorflow_script_mode_pipe_mode.ipynb \
3232
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_script_mode_quickstart/tensorflow_script_mode_quickstart.ipynb \
33-
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_serving_using_elastic_inference_with_your_own_model/tensorflow_serving_pretrained_model_elastic_inference.ipynb
33+
./amazon-sagemaker-examples/sagemaker-python-sdk/tensorflow_serving_using_elastic_inference_with_your_own_model/tensorflow_serving_pretrained_model_elastic_inference.ipynb \
34+
./amazon-sagemaker-examples/sagemaker-pipelines/tabular/abalone_build_train_deploy/sagemaker-pipelines-preprocess-train-evaluate-batch-transform.ipynb

0 commit comments

Comments
 (0)