Skip to content

Commit b8e8d61

Browse files
authored
test wait not called
1 parent 30092da commit b8e8d61

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

tests/unit/sagemaker/automl/test_auto_ml.py

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,18 @@ def test_auto_ml_only_one_of_problem_type_and_job_objective_provided(sagemaker_s
294294
)
295295

296296

297-
def test_auto_ml_additional_optional_params(sagemaker_session, caplog):
297+
@patch("sagemaker.automl.automl.AutoMLJob.start_new")
298+
def test_auto_ml_fit_set_logs_to_false(start_new, sagemaker_session, caplog):
299+
auto_ml = AutoML(
300+
role=ROLE, target_attribute_name=TARGET_ATTRIBUTE_NAME, sagemaker_session=sagemaker_session
301+
)
302+
inputs = DEFAULT_S3_INPUT_DATA
303+
auto_ml.fit(inputs, job_name=JOB_NAME, wait=False, logs=True)
304+
start_new.wait.assert_not_called()
305+
assert "Setting logs to False. logs is only meaningful when wait is True." in caplog.text
306+
307+
308+
def test_auto_ml_additional_optional_params(sagemaker_session):
298309
auto_ml = AutoML(
299310
role=ROLE,
300311
target_attribute_name=TARGET_ATTRIBUTE_NAME,
@@ -314,7 +325,7 @@ def test_auto_ml_additional_optional_params(sagemaker_session, caplog):
314325
tags=TAGS,
315326
)
316327
inputs = DEFAULT_S3_INPUT_DATA
317-
auto_ml.fit(inputs, job_name=JOB_NAME, wait=False, logs=True)
328+
auto_ml.fit(inputs, job_name=JOB_NAME)
318329
sagemaker_session.auto_ml.assert_called_once()
319330
_, args = sagemaker_session.auto_ml.call_args
320331

@@ -348,7 +359,6 @@ def test_auto_ml_additional_optional_params(sagemaker_session, caplog):
348359
"generate_candidate_definitions_only": GENERATE_CANDIDATE_DEFINITIONS_ONLY,
349360
"tags": TAGS,
350361
}
351-
assert "logs will be set to False. logs is only meaningful when wait is True." in caplog.text
352362

353363

354364
@patch("time.strftime", return_value=TIMESTAMP)

0 commit comments

Comments
 (0)