Skip to content

Commit bc8ed28

Browse files
author
Roja Reddy Sareddy
committed
resolve conflict dependency with numpy 2.0
1 parent 1d9bd7f commit bc8ed28

File tree

6 files changed

+13
-6
lines changed

6 files changed

+13
-6
lines changed

doc/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
sphinx==5.1.1
22
sphinx-rtd-theme==0.5.0
33
docutils==0.15.2
4-
packaging==20.9
4+
packaging>=23.0,<25
55
jinja2==3.1.6
66
schema==0.7.5
77
accelerate>=0.24.1,<=0.27.0

tests/data/serve_resources/mlflow/tensorflow/conda.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ dependencies:
66
- pip:
77
- mlflow>=2.16.1
88
- cloudpickle==2.2.1
9-
- numpy
9+
- numpy>=1.26.4
1010
- tensorflow==2.18.0
1111
name: mlflow-env
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
mlflow>=2.16.1
22
cloudpickle==2.2.1
3-
numpy
3+
numpy>=1.26.4
44
tensorflow==2.18.0

tests/data/serve_resources/mlflow/xgboost/conda.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ dependencies:
66
- pip:
77
- mlflow>=2.16.1
88
- lz4==4.3.2
9-
- numpy
9+
- numpy>=1.26.4
1010
- pandas==2.2.3
1111
- psutil==5.9.8
1212
- scikit-learn==1.6.1

tests/data/serve_resources/mlflow/xgboost/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
mlflow>=2.16.1
22
lz4==4.3.2
3-
numpy
3+
numpy>=1.26.4
44
pandas==2.2.3
55
psutil==5.9.8
66
scikit-learn==1.6.1

tests/unit/sagemaker/mlflow/test_forward_sagemaker_metrics.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ def getenv_side_effect(arg, default=None):
188188
Mock(spec=requests.Response),
189189
Mock(spec=requests.Response),
190190
],
191+
"https://test.sagemaker.aws/api/2.0/mlflow/runs/update": Mock(spec=requests.Response),
191192
"https://test.sagemaker.aws/api/2.0/mlflow/runs/terminate": Mock(spec=requests.Response),
192193
}
193194

@@ -215,13 +216,19 @@ def getenv_side_effect(arg, default=None):
215216
mock_response.status_code = 200
216217
mock_response.text = json.dumps({})
217218

219+
mock_responses["https://test.sagemaker.aws/api/2.0/mlflow/runs/update"].status_code = 200
220+
mock_responses["https://test.sagemaker.aws/api/2.0/mlflow/runs/update"].text = json.dumps(
221+
{"run_id": "test_run_id", "status": "FINISHED"}
222+
)
223+
218224
mock_responses["https://test.sagemaker.aws/api/2.0/mlflow/runs/terminate"].status_code = 200
219225
mock_responses["https://test.sagemaker.aws/api/2.0/mlflow/runs/terminate"].text = json.dumps({})
220226

221227
mock_request.side_effect = [
222228
mock_responses["https://test.sagemaker.aws/api/2.0/mlflow/experiments/get-by-name"],
223229
mock_responses["https://test.sagemaker.aws/api/2.0/mlflow/runs/create"],
224230
*mock_responses["https://test.sagemaker.aws/api/2.0/mlflow/runs/log-batch"],
231+
mock_responses["https://test.sagemaker.aws/api/2.0/mlflow/runs/update"],
225232
mock_responses["https://test.sagemaker.aws/api/2.0/mlflow/runs/terminate"],
226233
]
227234

@@ -231,7 +238,7 @@ def getenv_side_effect(arg, default=None):
231238

232239
log_to_mlflow(metrics, params, tags)
233240

234-
assert mock_request.call_count == 6 # Total number of API calls
241+
assert mock_request.call_count == 7 # Total number of API calls
235242

236243

237244
@patch("sagemaker.mlflow.forward_sagemaker_metrics.get_training_job_details")

0 commit comments

Comments
 (0)