Skip to content

Commit be8a19d

Browse files
authored
fix: default value removed if zero for integer param (#2409)
1 parent 012c4e8 commit be8a19d

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/sagemaker/workflow/parameters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def to_request(self) -> RequestType:
8080
"Name": self.name,
8181
"Type": self.parameter_type.value,
8282
}
83-
if self.default_value:
83+
if self.default_value is not None:
8484
value["DefaultValue"] = self.default_value
8585
return value
8686

tests/unit/sagemaker/workflow/test_parameters.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@ def test_parameter_with_default():
3737
assert param.to_request() == {"Name": "MyFloat", "Type": "Float", "DefaultValue": 1.2}
3838

3939

40+
def test_parameter_with_default_value_zero():
41+
param = ParameterInteger(name="MyInteger", default_value=0)
42+
assert param.to_request() == {"Name": "MyInteger", "Type": "Integer", "DefaultValue": 0}
43+
44+
4045
def test_parameter_string_with_enum_values():
4146
param = ParameterString("MyString", enum_values=["a", "b"])
4247
assert param.to_request() == {"Name": "MyString", "Type": "String", "EnumValues": ["a", "b"]}

0 commit comments

Comments
 (0)