Address feedback

Author: Ignacio Quintero

.pylintrc

@@ -30,30 +30,15 @@ disable=
     abstract-method,
     signature-differs
 
-
-
 [REPORTS]
 # Set the output format. Available formats are text, parseable, colorized, msvs
 # (visual studio) and html
 output-format=colorized
 
-
 # Tells whether to display a full report or only the messages
 # CHANGE: No report.
 reports=no
-# Python expression which should return a note less than 10 (10 is the highest
-# note). You have access to the variables errors warning, statement which
-# respectively contain the number of errors / warnings messages and the total
-# number of statements analyzed. This is used by the global evaluation report
-# (RP0004).
-#evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10)
-# Add a comment according to your evaluation note. This is used by the global
-# evaluation report (RP0004).
-#comment=no
 
-[MISCELLANEOUS]
-# List of note tags to take in consideration, separated by a comma.
-#notes=FIXME,XXX,TODO
 [FORMAT]
 # Maximum number of characters on a single line.
 max-line-length=100
@@ -64,19 +49,10 @@ max-line-length=100
 indent-string='  '
 
 [TYPECHECK]
-# Tells whether missing members accessed in mixin class should be ignored. A
-# mixin class is detected if its name ends with "mixin" (case insensitive).
-#ignore-mixin-members=yes
+
 # List of classes names for which member attributes should not be checked
 # (useful for classes with attributes dynamically set).
-ignored-classes=hashlib,numpy
-# When zope mode is activated, add a predefined set of Zope acquired attributes
-# to generated-members.
-#zope=no
-# List of members which are set dynamically and missed by pylint inference
-# system, and so shouldn't trigger E0201 when accessed.
-# CHANGE: Added 'AndRaise', 'AndReturn', 'InAnyOrder' and 'MultipleTimes' for pymox.
-# CHANGE: Added tempdir for @osutils.TempDirDecorator.
+ignored-classes=numpy
 generated-members=REQUEST,acl_users,aq_parent,AndRaise,AndReturn,InAnyOrder,MultipleTimes,tempdir
 
 [BASIC]
@@ -92,16 +68,6 @@ bad-functions=
     exit,
     input,
     quit,
-# Regular expression which should only match correct module names
-#module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
-# Regular expression which should only match correct module level names
-#const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$
-# Regular expression which should only match correct class names
-#class-rgx=[A-Z_][a-zA-Z0-9]+$
-# Regular expression which should only match correct function names
-#
-#
-
 
 [SIMILARITIES]
 # Minimum lines number of a similarity.
@@ -122,50 +88,7 @@ dummy-variables-rgx=_|unused_
 # you should avoid to define new builtins when possible.
 #additional-builtins=
 
-[DESIGN]
-# Maximum number of arguments for function / method
-#max-args=5
-
-# Argument names that match this expression will be ignored. Default to name
-# with leading underscore
-
-#ignored-argument-names=_.*
-# Maximum number of locals for function / method body
-#max-locals=15
-
-# Maximum number of return / yield for function / method body
-#max-returns=6
-
-# Maximum number of branch for function / method body
-#max-branchs=12
-
-# Maximum number of statements in function / method body
-#max-statements=50
-
-# Maximum number of parents for a class (see R0901).
-max-parents=10
-
-# Maximum number of attributes for a class (see R0902).
-#max-attributes=7
-
-# Minimum number of public methods for a class (see R0903).
-#min-public-methods=2
-
-# Maximum number of public methods for a class (see R0904).
-#max-public-methods=20
-
-[IMPORTS]
-# Create a graph of every (i.e. internal and external) dependencies in the
-# given file (report RP0402 must not be disabled)
-#import-graph=
-# Create a graph of external dependencies in the given file (report RP0402 must
-# not be disabled)
-#ext-import-graph=
-# Create a graph of internal dependencies in the given file (report RP0402 must
-# not be disabled)
-#int-import-graph=
-
 [LOGGING]
 # Apply logging string format checks to calls on these modules.
 logging-modules=
-    logging
+    logging

CHANGELOG.rst

@@ -4,7 +4,8 @@ CHANGELOG
 
 1.14.1dev
 =========
-* bug-fix: rename MXNet argument from accelerators -> accelerator
+
+* breaking-change: rename MXNet argument from distributions -> distribution
 
 1.14.0
 ======

src/sagemaker/estimator.py

@@ -247,7 +247,7 @@ def attach(cls, training_job_name, sagemaker_session=None, model_channel_name='m
 
         estimator = cls(sagemaker_session=sagemaker_session, **init_params)
         estimator.latest_training_job = _TrainingJob(sagemaker_session=sagemaker_session,
-                                                     training_job_name=init_params['base_job_name'])
+                                                     job_name=init_params['base_job_name'])
         estimator.latest_training_job.wait()
         return estimator
 
@@ -410,9 +410,6 @@ def _ensure_latest_training_job(self, error_message='Estimator is not associated
 
 
 class _TrainingJob(_Job):
-    def __init__(self, sagemaker_session, training_job_name):  # pylint: disable=useless-super-delegation
-        super(_TrainingJob, self).__init__(sagemaker_session, training_job_name)
-
     @classmethod
     def start_new(cls, estimator, inputs):
         """Create a new Amazon SageMaker training job from the estimator.

src/sagemaker/tuner.py

@@ -70,6 +70,10 @@ def as_tuning_range(self, name):
 
 class ContinuousParameter(_ParameterRange):
     """A class for representing hyperparameters that have a continuous range of possible values.
+
+    Args:
+            min_value (float): The minimum value for the range.
+            max_value (float): The maximum value for the range.
     """
     __name__ = 'Continuous'
 
@@ -121,6 +125,10 @@ def as_json_range(self, name):
 
 class IntegerParameter(_ParameterRange):
     """A class for representing hyperparameters that have an integer range of possible values.
+
+        Args:
+            min_value (int): The minimum value for the range.
+            max_value (int): The maximum value for the range.
     """
     __name__ = 'Integer'