Skip to content

Commit cc5ce94

Browse files
authored
Merge branch 'master' into add_dlc_training_new_regions
2 parents 105f23a + 2c3b3fa commit cc5ce94

File tree

7 files changed

+28
-12
lines changed

7 files changed

+28
-12
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
# Changelog
22

3+
## v2.135.0 (2023-02-23)
4+
5+
### Features
6+
7+
* Add DLC accounts for MEL Region
8+
* allow use of short lived creds for local container
9+
10+
### Bug Fixes and Other Changes
11+
12+
* update lambda function when function arn is provided
13+
314
## v2.134.1 (2023-02-22)
415

516
### Bug Fixes and Other Changes

README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ To run the unit tests with tox, run:
126126

127127
tox tests/unit
128128

129-
**Integrations tests**
129+
**Integration tests**
130130

131131
To run the integration tests, the following prerequisites must be met
132132

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.134.2.dev0
1+
2.135.1.dev0

requirements/extras/test_requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ black==22.3.0
1313
stopit==1.1.2
1414
# Update tox.ini to have correct version of airflow constraints file
1515
apache-airflow==2.4.1
16-
apache-airflow-providers-amazon==4.0.0
16+
apache-airflow-providers-amazon==7.2.1
1717
attrs==22.1.0
1818
fabric==2.6.0
1919
requests==2.27.1

src/sagemaker/feature_store/feature_group.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -473,11 +473,12 @@ class FeatureGroup:
473473
Attributes:
474474
name (str): name of the FeatureGroup instance.
475475
sagemaker_session (Session): session instance to perform boto calls.
476+
If None, a new Session will be created.
476477
feature_definitions (Sequence[FeatureDefinition]): list of FeatureDefinitions.
477478
"""
478479

479480
name: str = attr.ib(factory=str)
480-
sagemaker_session: Session = attr.ib(default=Session)
481+
sagemaker_session: Session = attr.ib(factory=Session)
481482
feature_definitions: Sequence[FeatureDefinition] = attr.ib(factory=list)
482483

483484
_INTEGER_TYPES = [

src/sagemaker/git_utils.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ def _clone_command_for_github_like(git_config, dest_dir):
174174
CalledProcessError: If failed to clone git repo.
175175
"""
176176
is_https = git_config["repo"].startswith("https://")
177-
is_ssh = git_config["repo"].startswith("git@")
177+
is_ssh = git_config["repo"].startswith("git@") or git_config["repo"].startswith("ssh://")
178178
if not is_https and not is_ssh:
179179
raise ValueError("Invalid Git url provided.")
180180
if is_ssh:
@@ -277,12 +277,16 @@ def _run_clone_command(repo_url, dest_dir):
277277
if repo_url.startswith("https://"):
278278
my_env["GIT_TERMINAL_PROMPT"] = "0"
279279
subprocess.check_call(["git", "clone", repo_url, dest_dir], env=my_env)
280-
elif repo_url.startswith("git@"):
281-
with tempfile.NamedTemporaryFile() as sshnoprompt:
282-
with open(sshnoprompt.name, "w") as write_pipe:
283-
write_pipe.write("ssh -oBatchMode=yes $@")
284-
os.chmod(sshnoprompt.name, 0o511)
285-
my_env["GIT_SSH"] = sshnoprompt.name
280+
elif repo_url.startswith("git@") or repo_url.startswith("ssh://"):
281+
try:
282+
with tempfile.NamedTemporaryFile() as sshnoprompt:
283+
with open(sshnoprompt.name, "w") as write_pipe:
284+
write_pipe.write("ssh -oBatchMode=yes $@")
285+
os.chmod(sshnoprompt.name, 0o511)
286+
my_env["GIT_SSH"] = sshnoprompt.name
287+
subprocess.check_call(["git", "clone", repo_url, dest_dir], env=my_env)
288+
except subprocess.CalledProcessError:
289+
del my_env["GIT_SSH"]
286290
subprocess.check_call(["git", "clone", repo_url, dest_dir], env=my_env)
287291

288292

tests/unit/sagemaker/image_uris/test_graviton.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"r6g",
2828
"r6gd",
2929
]
30-
GRAVITON_ALGOS = ("tensorflow", "pytotch")
30+
GRAVITON_ALGOS = ("tensorflow", "pytorch")
3131
GRAVITON_INSTANCE_TYPES = [
3232
"ml.m6g.4xlarge",
3333
"ml.m6gd.2xlarge",

0 commit comments

Comments
 (0)