Skip to content

Commit d03bca3

Browse files
committed
one more straggler
1 parent 53cace5 commit d03bca3

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/sagemaker/chainer/estimator.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
import logging
1717

18-
from sagemaker import utils
1918
from sagemaker.estimator import Framework
2019
from sagemaker.fw_utils import (
2120
framework_name_from_image,
@@ -207,13 +206,11 @@ def create_model(
207206
sagemaker.chainer.model.ChainerModel: A SageMaker ``ChainerModel``
208207
object. See :func:`~sagemaker.chainer.model.ChainerModel` for full details.
209208
"""
209+
kwargs["name"] = self._get_or_create_name(kwargs.get("name"))
210+
210211
if "image" not in kwargs:
211212
kwargs["image"] = self.image_name
212213

213-
if "name" not in kwargs:
214-
self._ensure_base_job_name()
215-
kwargs["name"] = utils.name_from_base(self.base_job_name)
216-
217214
return ChainerModel(
218215
self.model_data,
219216
role or self.role,

src/sagemaker/rl/estimator.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,6 @@ def create_model(
218218
Raises:
219219
ValueError: If image_name is not specified and framework enum is not valid.
220220
"""
221-
222221
base_args = dict(
223222
model_data=self.model_data,
224223
role=role or self.role,

0 commit comments

Comments
 (0)