Fix integ test + address some comments

Author: Ignacio Quintero

src/sagemaker/local/entities.py

@@ -285,18 +285,18 @@ def _perform_batch_inference(self, input_data, output_data, **kwargs):
             copy_directory_structure(working_dir, relative_path)
             destination_path = os.path.join(working_dir, relative_path, filename + '.out')
 
-            with open(destination_path, 'w') as f:
+            with open(destination_path, 'wb') as f:
                 for item in batch_provider.pad(file, max_payload):
                     # call the container and add the result to inference.
                     response = self.local_session.sagemaker_runtime_client.invoke_endpoint(
                         item, '', input_data['ContentType'], accept)
 
                     response_body = response['Body']
-                    data = response_body.read()
+                    data = response_body.read().strip()
                     response_body.close()
                     f.write(data)
                     if 'AssembleWith' in output_data and output_data['AssembleWith'] == 'Line':
-                        f.write('\n')
+                        f.write(b'\n')
 
         move_to_destination(working_dir, output_data['S3OutputPath'], self.local_session)
         self.container.stop_serving()

src/sagemaker/transformer.py

@@ -31,7 +31,7 @@ def __init__(self, model_name, instance_count, instance_type, strategy=None, ass
             instance_count (int): Number of EC2 instances to use.
             instance_type (str): Type of EC2 instance to use, for example, 'ml.c4.xlarge'.
             strategy (str): The strategy used to decide how to batch records in a single request (default: None).
-                Valid values: 'MULTI_RECORD' and 'SINGLE_RECORD'.
+                Valid values: 'MultiRecord' and 'SingleRecord'.
             assemble_with (str): How the output is assembled (default: None). Valid values: 'Line' or 'None'.
             output_path (str): S3 location for saving the transform result. If not specified, results are stored to
                 a default bucket.

tests/integ/test_local_mode.py

@@ -390,7 +390,8 @@ def test_local_transform_mxnet(sagemaker_local_session, tmpdir):
                                                        key_prefix=transform_input_key_prefix)
 
     output_path = 'file://%s' % (str(tmpdir))
-    transformer = mx.transformer(1, 'local', assemble_with='Line', max_payload=1, output_path=output_path)
+    transformer = mx.transformer(1, 'local', assemble_with='Line', max_payload=1,
+                                 strategy='SingleRecord', output_path=output_path)
     transformer.transform(transform_input, content_type='text/csv', split_type='Line')
     transformer.wait()
 

tests/unit/test_local_data.py

@@ -103,8 +103,7 @@ def test_get_splitter_instance_with_valid_types():
 
 def test_get_splitter_instance_with_invalid_types():
     with pytest.raises(ValueError):
-        # something invalid
-        sagemaker.local.data.get_splitter_instance('JSON')
+        sagemaker.local.data.get_splitter_instance('SomethingInvalid')
 
 
 def test_none_splitter(tmpdir):
@@ -133,7 +132,6 @@ def test_line_splitter(tmpdir):
 
 
 def test_recordio_splitter(tmpdir):
-
     test_file_path = tmpdir.join('recordio_test.txt')
     with test_file_path.open('wb') as f:
         for i in range(10):