Skip to content

Commit e63de84

Browse files
author
Jonathan Makunga
committed
Addressed PR Review comments
1 parent c615842 commit e63de84

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/sagemaker/serve/builder/jumpstart_builder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
)
4343
from sagemaker.serve.utils.telemetry_logger import _capture_telemetry
4444
from sagemaker.serve.utils.tuning import (
45-
_pretty_print_benchmark_results,
45+
_pretty_print_results_jumpstart,
4646
_serial_benchmark,
4747
_concurrent_benchmark,
4848
_more_performant,
@@ -386,7 +386,7 @@ def _tune_for_js(self, max_tuning_duration: int = 1800):
386386
if best_tuned_combination:
387387
self.pysdk_model.env.update({num_shard_env_var_name: str(best_tuned_combination[1])})
388388

389-
_pretty_print_benchmark_results(benchmark_results, [num_shard_env_var_name])
389+
_pretty_print_results_jumpstart(benchmark_results, [num_shard_env_var_name])
390390
logger.info(
391391
"Model Configuration: %s was most performant with avg latency: %s, "
392392
"p90 latency: %s, average tokens per second: %s, throughput/s: %s, "

src/sagemaker/serve/utils/tuning.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ def _pretty_print_results_tgi(results: dict):
9999
)
100100

101101

102-
def _pretty_print_benchmark_results(results: dict, model_env_vars=None):
102+
def _pretty_print_results_jumpstart(results: dict, model_env_vars=None):
103103
"""Pretty prints benchmark results"""
104104
if model_env_vars is None:
105105
model_env_vars = []

0 commit comments

Comments
 (0)