fix formatting/linting suggestions

Author: siddvenk

src/sagemaker/djl_inference/djl_predictor.py

@@ -1,3 +1,17 @@
+# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"). You
+# may not use this file except in compliance with the License. A copy of
+# the License is located at
+#
+#     http://aws.amazon.com/apache2.0/
+#
+# or in the "license" file accompanying this file. This file is
+# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
+# ANY KIND, either express or implied. See the License for the specific
+# language governing permissions and limitations under the License.
+"""Default Predictor for JSON inputs/outputs used with DJL LMI containers"""
+from __future__ import absolute_import
 from sagemaker.predictor import Predictor
 from sagemaker import Session
 from sagemaker.serializers import BaseSerializer, JSONSerializer

src/sagemaker/djl_inference/model.py

@@ -28,6 +28,7 @@
 def _set_env_var_from_property(
     property_value: Optional[Any], env_key: str, env: dict, override_env_var=False
 ) -> dict:
+    """Utility method to set an environment variable configuration"""
     if not property_value:
         return env
     if override_env_var or env_key not in env:
@@ -129,20 +130,23 @@ def __init__(
         self._initialize_model()
 
     def _initialize_model(self):
+        """Placeholder docstring"""
         self._validate_model_artifacts()
         self.engine = self._infer_engine()
         self.env = self._configure_environment_variables()
         self.image_uri = self._infer_image_uri()
 
     def _validate_model_artifacts(self):
+        """Placeholder docstring"""
         if self.model_id is not None and self.model_data is not None:
             raise ValueError(
                 "both model_id and model_data are provided. Please only provide one of them"
             )
 
     def _infer_engine(self) -> Optional[str]:
+        """Placeholder docstring"""
         if self.engine is not None:
-            logger.info(f"Using provided engine {self.engine}")
+            logger.info("Using provided engine %s", self.engine)
             return self.engine
 
         if self.task is not None:
@@ -151,6 +155,7 @@ def _infer_engine(self) -> Optional[str]:
         return "Python"
 
     def _infer_image_uri(self):
+        """Placeholder docstring"""
         if self.image_uri is not None:
             return self.image_uri
         if self.djl_framework is None:
@@ -162,6 +167,7 @@ def _infer_image_uri(self):
         )
 
     def _configure_environment_variables(self) -> Dict[str, str]:
+        """Placeholder docstring"""
         env = self.env.copy() if self.env else {}
         env = _set_env_var_from_property(self.model_id, "HF_MODEL_ID", env)
         env = _set_env_var_from_property(self.task, "HF_TASK", env)
@@ -188,6 +194,7 @@ def serving_image_uri(
         accelerator_type=None,
         serverless_inference_config=None,
     ):
+        """Placeholder docstring"""
         if self.image_uri:
             return self.image_uri
         return image_uris.retrieve(

src/sagemaker/serve/builder/djl_builder.py

@@ -255,7 +255,6 @@ def _build_for_hf_djl(self):
             self.schema_builder.sample_input["parameters"][
                 "max_new_tokens"
             ] = _default_max_new_tokens
-        logger.info(f"env vars are {self.env_vars}")
         self.pysdk_model = self._create_djl_model()
 
         if self.mode == Mode.LOCAL_CONTAINER:

src/sagemaker/serve/utils/hf_utils.py

@@ -1,3 +1,17 @@
+# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"). You
+# may not use this file except in compliance with the License. A copy of
+# the License is located at
+#
+#     http://aws.amazon.com/apache2.0/
+#
+# or in the "license" file accompanying this file. This file is
+# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
+# ANY KIND, either express or implied. See the License for the specific
+# language governing permissions and limitations under the License.
+"""Utility functions for fetching model information from HuggingFace Hub"""
+from __future__ import absolute_import
 import json
 import urllib.request
 from json import JSONDecodeError

tests/unit/test_djl_inference.py

@@ -12,12 +12,8 @@
 # language governing permissions and limitations under the License.
 from __future__ import absolute_import
 
-import json
-from json import JSONDecodeError
-
 import pytest
-from mock import Mock, MagicMock
-from mock import patch
+from mock import Mock
 
 from sagemaker.djl_inference import (
     DJLModel,