fix: remove trailing slash when uploading to S3 with dataset_builder.to_csv_file

mkkatica · mkkatica · commit f6355519c528 · 2024-04-09T17:24:14.000-04:00
diff --git a/src/sagemaker/feature_store/dataset_builder.py b/src/sagemaker/feature_store/dataset_builder.py
@@ -431,7 +431,7 @@ def to_csv_file(self) -> Tuple[str, str]:
             self._base.to_csv(local_file_name, index=False, header=False)
             s3.S3Uploader.upload(
                 local_path=local_file_name,
-                desired_s3_uri=desired_s3_folder,
+                desired_s3_uri=desired_s3_folder.rstrip("/"),
                 sagemaker_session=self._sagemaker_session,
                 kms_key=self._kms_key_id,
             )

Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ def to_csv_file(self) -> Tuple[str, str]:`
`431`	`431`	`self._base.to_csv(local_file_name, index=False, header=False)`
`432`	`432`	`s3.S3Uploader.upload(`
`433`	`433`	`local_path=local_file_name,`
`434`		`- desired_s3_uri=desired_s3_folder,`
	`434`	`+ desired_s3_uri=desired_s3_folder.rstrip("/"),`
`435`	`435`	`sagemaker_session=self._sagemaker_session,`
`436`	`436`	`kms_key=self._kms_key_id,`
`437`	`437`	`)`