Skip to content

change: remove red from possible colors when streaming logs #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2019
Merged

change: remove red from possible colors when streaming logs #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de13298
change: remove red from possible colors when streaming logs
laurenyu Nov 13, 2019
f5a9996
work around botocore pin
laurenyu Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/sagemaker/logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2017-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
# Copyright 2017-2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"). You
# may not use this file except in compliance with the License. A copy of
Expand Down Expand Up @@ -31,7 +31,9 @@ class ColorWrap(object):
cell).
"""

_stream_colors = [31, 32, 33, 34, 35, 36]
# For what color each number represents, see
# https://misc.flogisoft.com/bash/tip_colors_and_formatting#colors
_stream_colors = [34, 35, 32, 36, 33]

def __init__(self, force=False):
"""Initialize the class.
Expand Down
4 changes: 4 additions & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ passenv =

# {posargs} can be passed in by additional arguments specified when invoking tox.
# Can be used to specify which tests to run, e.g.: tox -- -s
# TODO: Remove pip install python-dateutil==2.8.0 once botocore no longer requires a pinned version
commands =
pip install python-dateutil==2.8.0
coverage run --source sagemaker -m pytest {posargs}
{env:IGNORE_COVERAGE:} coverage report --fail-under=90 --omit */tensorflow/tensorflow_serving/*
extras = test
Expand Down Expand Up @@ -112,7 +114,9 @@ deps =
# pip install requirements.txt is separate as RTD does it in separate steps
# having the requirements.txt installed in deps above results in Double Requirement exception
# https://github.com/pypa/pip/issues/988
# TODO: Remove pip install python-dateutil==2.8.0 once botocore no longer requires a pinned version
commands =
pip install python-dateutil==2.8.0
pip install --exists-action=w -r requirements.txt
sphinx-build -T -W -b html -d _build/doctrees-readthedocs -D language=en . _build/html

Expand Down