fix: create auto ml job for tests that based on existing job #1151
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
tests/integ/test_auto_ml.py
Outdated
| @@ -62,6 +62,11 @@ | |||
| } | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="module", autouse=True) | |||
| def create_auto_ml_job_if_not_exist(sagemaker_session): | |||
There was a problem hiding this comment.
what test is using this fixture?
There was a problem hiding this comment.
This fixture is autouse, all test methods in the class will use this fixture without a need to state it in the test function signature. But now a second thought made me realized not all tests in the class are using this fixture, I will apply it to individual tests.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| ) | ||
|
|
||
| try: | ||
| auto_ml.describe_auto_ml_job(job_name=auto_ml_job_name) |
There was a problem hiding this comment.
Don't fix it as part of this PR, but we should have a session method for this if the base object isn't needed. Feel free to chat in person if I'm missing something.
i.e.:
session.describe_auto_ml_job(job_name)
Meaning that, if we don't need anything from the object, we should just use a session method.
There was a problem hiding this comment.
Got it! Thanks! Yes a session method doing that makes more sense!
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #, if available:
Description of changes:
For auto ml jobs, create a base auto ml job for tests that base on an existing auto ml job.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.